Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support adding custom fonts #270

Closed
Visne opened this issue Sep 29, 2023 · 1 comment · Fixed by #304
Closed

[Feature Request] Support adding custom fonts #270

Visne opened this issue Sep 29, 2023 · 1 comment · Fixed by #304
Labels
enhancement New feature or request

Comments

@Visne
Copy link

Visne commented Sep 29, 2023

What do you want to be added?

Apologies if this is already possible (wouldn't mind diving into files), but it would be cool if you could add a custom font for content, or if you could select from all fonts installed on your system.

@Visne Visne added the enhancement New feature or request label Sep 29, 2023
@Nik-mmzd
Copy link

Nik-mmzd commented Oct 7, 2023

+1 for the issue, default ones do not contain a lot of symbols and it looks weird when missing symbols are replaced with another font.

P.S. I see no need in selecting any installed font, "System Default" font setting will be enough

kgarner7 added a commit to kgarner7/feishin that referenced this issue Oct 14, 2023
Uses the **experimental** queryLocalFonts API, when prompted, to get the fonts and do CSS.
Resolves jeffvli#270 and jeffvli#288 (by proxy)

Caveats/notes:
- This is experimental, and is only supported by Chrome/Chromium/Edgeium (see https://caniuse.com/?search=querylocalfonts)
- As far as I can tell, the only way to dynamically change the font (shown in https://wicg.github.io/local-font-access/#example-style-with-local-fonts) was by DOM manipulation; css variables did not seem to work
- This shows **all** fonts, including their variants (bold/italic/etc); given that the style names could be localized, not sure of a way to parse this (on my system, for instance, I had 859 different combinations)
- I made fonts a separate top-level setting because it was easier to manipulate without causing as many rerenders; feel free to put that back
jeffvli pushed a commit that referenced this issue Oct 22, 2023
* [feature]: Support using system fonts

Uses the **experimental** queryLocalFonts API, when prompted, to get the fonts and do CSS.
Resolves #270 and #288 (by proxy)

Caveats/notes:
- This is experimental, and is only supported by Chrome/Chromium/Edgeium (see https://caniuse.com/?search=querylocalfonts)
- As far as I can tell, the only way to dynamically change the font (shown in https://wicg.github.io/local-font-access/#example-style-with-local-fonts) was by DOM manipulation; css variables did not seem to work
- This shows **all** fonts, including their variants (bold/italic/etc); given that the style names could be localized, not sure of a way to parse this (on my system, for instance, I had 859 different combinations)
- I made fonts a separate top-level setting because it was easier to manipulate without causing as many rerenders; feel free to put that back

* add permission chec

* add electron magic to support custom font

* restrict content types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants