Allow the overlapping() function to take ranges by value
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of forcing the user of the API to pass a range by reference, which causes the resulting iterator to have a lifetime which depends on this reference, the `Borrow` trait is used to give the user a choice to use either a reference or pass the range by value. The lifetime of the iterator accordingly depends on which of the two is chosen.
|
Thanks for this, @xfbs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of forcing the user of the
overlapping()API to pass a range by reference, which causes the resulting iterator to have a lifetime which depends on this reference, theBorrowtrait is used to give the user a choice to use either a reference or pass the range by value. The lifetime of the iterator accordingly depends on which of the two is chosen.This pull request achieves a similar end as #70, however it does not break the existing API and allows for greater flexibility (giving the user of the API the choice of either passing the range as reference or passing a range by value.