Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make input a required argument to fetch #207

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Make input a required argument to fetch #207

merged 1 commit into from
Sep 2, 2021

Conversation

keeganwatkins
Copy link
Contributor

@keeganwatkins keeganwatkins commented Jun 25, 2021

See #206 , this is an attempt to correct the type definitions for the mocked fetch.

I ran the unit tests, tsc, and lint locally, but I'm unsure what else I should be checking.

@keeganwatkins keeganwatkins changed the title Make a required argument to fetch Make input a required argument to fetch Jun 25, 2021
@yinzara
Copy link
Collaborator

yinzara commented Sep 2, 2021

This is correct. Thanks for the fix.

@yinzara yinzara merged commit 79e79e8 into jefflau:master Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants