Parse operation configs only if they are specified #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the config unit tests need some additional work since these flags aren't passed there |
|
Updated the unit tests to set the required flags, but do they need to be outside the function so that they are guaranteed to be available everywhere? I'm not sure how golang's testing works as far as threading and such. |
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
- Coverage 40.36% 40.29% -0.07%
==========================================
Files 12 12
Lines 934 938 +4
==========================================
+ Hits 377 378 +1
- Misses 515 517 +2
- Partials 42 43 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where duplicacy-util tries to parse configurations for all operations, even when they aren't specified. Now each configuration is only parsed when the corresponding
cmd*flag is passed. It does not change any behavior for the end user.performBackup()inbackup-ops.gocorrectly honors these flags already, so not parsing the configs should not break anything.