chore(misc): tiny improvements #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! |
jef
approved these changes
Sep 23, 2020
shivasdaddy
added a commit
to shivasdaddy/nvidia-snatcher
that referenced
this pull request
Sep 23, 2020
This reverts commit 8466f9f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preface: Please let me know if I need a better title.
Description
Improvement 1: I alphabetically sorted some lists in
README.MD.Improvement 2: I added better handling for when the user enters an invalid store name. If they enter an invalid name, it'll print a warning instead of throwing an exception, and if they don't enter any valid names, the app will quit right away.
Improvement 3: To stop more issues like #116 popping up, I added some descriptive logging around the big block of "INFO: Could not find files for the given pattern(s)." output.
Discord: sergo#8847
Testing
STORES="nvidia"STORES="invalid-store"