feat(store): add materiel.net (FR) #2084
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirjeannot
changed the title
sirjeannot
changed the title
jef
requested changes
Mar 26, 2021
src/store/model/store.ts
Outdated
Comment on lines
148
to
150
| | 'rog strix' | ||
| | 'rog strix oc' | ||
| | 'rog strix oc white' |
There was a problem hiding this comment.
Suggested change
| | 'rog strix' | |
| | 'rog strix oc' | |
| | 'rog strix oc white' |
Do you mind using the strix oc, strix, etc. We removed the rog as it's part of the brand.
There was a problem hiding this comment.
the cleanup is done 👍
tested and ok.
|
Hi @sirjeannot, Sorry to say, but some of this code got superseded by #1836. Are you able to resolve the conflicts? If so, I can pull it in afterward! Thanks. |
chore: release 3.6.0
|
done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello,
pull request to add fr shop materiel.net.
some models were also added as all models listed on the shop were included, except watercooled card not AiO.
even through the shop is called 'materiel.net', I named it materielnet in case...
Thanks!
Testing
Testing done on my end using docker, works fine. Reports correctly price, instock and not instock.
New dependencies
None!