-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(notification): add Streamlabs support #1872
Conversation
Over the weekend I will fix the linting problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Query params kind of make sense, but we also didn't make the API! That being said, I feel like authentication shouldn't be sent as a query param, but unfortunately, it is.
Overall, looks good to me!
Thanks for the implementation 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, just a couple comments. This is great overall; awesome addition!
Co-authored-by: Jef LeCompte <[email protected]>
Co-authored-by: Jef LeCompte <[email protected]>
Description
Added the ability to activate alerts via StreamLabs
Requires the user to register with StreamLabs and create an application to request an access token (no need to submit for review).
Useful for sending sound notifications to viewers of a live stream.
Testing
Ran the test notification script
New dependencies
form-data