Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aead Api #131

Merged
merged 10 commits into from Apr 19, 2018
Merged

Aead Api #131

merged 10 commits into from Apr 19, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 22, 2018

@jedisct1
Copy link
Owner

Thanks!

Just two things:

  • additionalData should probably be optional. Maybe by providing additional functions that don't require it, similar to what is being done in other classes.
  • Would it be possible to update the doc as well?

Thanks!

@ghost
Copy link
Author

ghost commented Mar 22, 2018

Sure, I am doing it now, and I will add detached mode too

@ghost
Copy link
Author

ghost commented Mar 22, 2018

@ghost
Copy link
Author

ghost commented Mar 22, 2018

I think this can be merged, when I have some time I will push detached mode too

@jedisct1 jedisct1 merged commit 8df5a4a into jedisct1:master Apr 19, 2018
@aidantwoods
Copy link
Collaborator

Thanks for adding this in @umbri :)

@aidantwoods aidantwoods mentioned this pull request Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants