Update for django-reversion 2.04 #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshannon1123
commented
Jun 28, 2016
mshannon1123
commented
- Sorry for the large PR, but included is some pep8 cleanup and optimizations
- Unit Tests pass locally
- Testing ok with django-reversion 2.04 and Oracle as DB
|
Thanks for your contribution! Please change .travis.yml, so that the tests runs also against django-reversion v2 ;) |
| @@ -91,9 +84,9 @@ def __eq__(self, other): | |||
| return False | |||
|
|
|||
| # see - https://hynek.me/articles/hasattr/ | |||
| internal_type = getattr(self.field,'get_internal_type',None) | |||
| if internal_type is None or internal_type() == "ForeignKey": # FIXME! | |||
mshannon1123
force-pushed
the
master
branch
2 times, most recently
from
19ee6cc to
c427a18
Compare
|
@jedie I pushed up and corrected a cross-compatibility error. Let me know if you see anything else. |
|
|
||
| if missing_objects: | ||
| result.append("missing m2m objects: %s" % repr(missing_objects)) | ||
| result.append("missing m2m objects: %s" % repr(missing_objects)) |
|
Just a ping to remind if you have a moment to review this change. |
|
This will be great. |
| - DJANGO='1.9' REVERSION='1.10' EXTRA='diff-match-patch' | ||
| - DJANGO='1.9' REVERSION='2.0.4' EXTRA='diff-match-patch' |
There was a problem hiding this comment.
I think "2.0.4" is too limited. (Current django-reversion version is 2.0.6)
Why not use "2.0" ?
|
Think it makes sense to support only django-reversion >= 2.x |
|
Please take a look at #76 ;) |
|
v0.7.0 released on PyPi and will support django-reversion v2.0.x |
|
Looked great, thanks for the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.