Check if related model has an integer as pk for ManyToMany fields. #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a model (Station) that uses UUID as pk, and it has an ManyToMany relation to a model (Entity) that uses integers as pk. With current implementation I get an exception because Station.has_int_pk() returns False (as it should), so ids is None when we call
get_many_to_something()
. It should check if the related model has integers as pk, because it's the related model ids when want in our query.I guess there should be an else statement where ids is set to
self.value
, if the related model uses string as pk?