Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show username and full name from custom user model #112

Merged
merged 1 commit into from
Jan 19, 2020

Conversation

berekuk
Copy link
Contributor

@berekuk berekuk commented Nov 4, 2019

This is the port of the commit etianen/django-reversion@ae82a83 from the original django-reversion template.

Without this patch, the User column in the object history view is always empty if your User model doesn't have a username or full name.

This is a port of the commit
etianen/django-reversion@ae82a83
from the original django-reversion template.
@coveralls
Copy link

coveralls commented Nov 4, 2019

Coverage Status

Coverage decreased (-0.02%) to 85.195% when pulling cb0d226 on berekuk:custom-user-models into fbf322f on jedie:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.217% when pulling cb0d226 on berekuk:custom-user-models into fbf322f on jedie:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.217% when pulling cb0d226 on berekuk:custom-user-models into fbf322f on jedie:master.

@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #112 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   78.47%   78.47%           
=======================================
  Files           4        4           
  Lines         432      432           
  Branches      103      103           
=======================================
  Hits          339      339           
  Misses         69       69           
  Partials       24       24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbf322f...cb0d226. Read the comment docs.

@willtho89
Copy link
Contributor

@jedie any update on this?

@jedie jedie merged commit ca13f53 into jedie:master Jan 19, 2020
@jedie
Copy link
Owner

jedie commented Jan 19, 2020

Thanks for contribution.

@jedie
Copy link
Owner

jedie commented Jan 19, 2020

it's included in the v0.9 release: https://pypi.org/project/django-reversion-compare/0.9.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants