Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Django 2.0 compatibility #102

Merged
merged 1 commit into from
Dec 29, 2017
Merged

Add Django 2.0 compatibility #102

merged 1 commit into from
Dec 29, 2017

Conversation

samifahed
Copy link
Contributor

@samifahed samifahed commented Dec 29, 2017

This adds compatibility to Django 2.0
The change also includes add django2 to tox so it runs the tests against it as well.

@coveralls
Copy link

coveralls commented Dec 29, 2017

Coverage Status

Coverage remained the same at 85.147% when pulling c3eabb9 on Thermondo:master into 2a83c47 on jedie:master.

@codecov
Copy link

codecov bot commented Dec 29, 2017

Codecov Report

Merging #102 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   78.52%   78.52%           
=======================================
  Files           4        4           
  Lines         433      433           
  Branches      104      104           
=======================================
  Hits          340      340           
  Misses         70       70           
  Partials       23       23
Impacted Files Coverage Δ
reversion_compare/compare.py 85.99% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a83c47...e0aac3e. Read the comment docs.

@coveralls
Copy link

coveralls commented Dec 29, 2017

Coverage Status

Coverage remained the same at 85.147% when pulling e0aac3e on Thermondo:master into 2a83c47 on jedie:master.

@jedie
Copy link
Owner

jedie commented Dec 29, 2017

Great! Thanks for contributing!

@jedie jedie merged commit 334fdb6 into jedie:master Dec 29, 2017
@jedie
Copy link
Owner

jedie commented Mar 15, 2018

Wow, i really forgotten to publish in PyPi :(

I've done this now: https://pypi.org/project/django-reversion-compare/0.8.4/

Thanks for reminder ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants