New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version 0.7 only works if ADD_REVERSION_ADMIN = True #79

Closed

LegoStormtroopr opened this issue Aug 29, 2016 · 1 comment

Contributor

LegoStormtroopr commented Aug 29, 2016

From here: https://github.com/jedie/django-reversion-compare/blob/master/reversion_compare/admin.py#L225

If ADD_REVERSION_ADMIN = False or not set, Version is never imported into admin.py and Reversion compare fails on line 166

I don't really want Reversions/Versions showing up in my admin page, so it should be possible to just move the import to the top of the module.

The text was updated successfully, but these errors were encountered:

Owner

jedie commented Aug 29, 2016

Wow. Interesting. The unittests will not catch this case :(
Think there is not really a easy was to test this, isn't it?

jedie closed this as completed in

265c88a

jedie added a commit that referenced this issue


          Fix #79

c8517a6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment