-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
table: fix paging with separators; fixes #312 #313
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quality Gate passedIssues Measures |
Pull Request Test Coverage Report for Build 8572577894Details
💛 - Coveralls |
another-rex
referenced
this pull request
in google/osv-scanner
Apr 9, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | [deps.dev/api/v3](https://togithub.com/google/deps.dev) | require | digest | `ff53416` -> `d32937c` | | | | | | [deps.dev/util/maven](https://togithub.com/google/deps.dev) | require | digest | `ff53416` -> `d32937c` | | | | | | [deps.dev/util/resolve](https://togithub.com/google/deps.dev) | require | digest | `ff53416` -> `d32937c` | | | | | | [deps.dev/util/semver](https://togithub.com/google/deps.dev) | require | digest | `ff53416` -> `d32937c` | | | | | | [github.com/gkampitakis/go-snaps](https://togithub.com/gkampitakis/go-snaps) | require | patch | `v0.5.2` -> `v0.5.3` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgkampitakis%2fgo-snaps/v0.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgkampitakis%2fgo-snaps/v0.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgkampitakis%2fgo-snaps/v0.5.2/v0.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgkampitakis%2fgo-snaps/v0.5.2/v0.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/go-git/go-git/v5](https://togithub.com/go-git/go-git) | require | minor | `v5.11.0` -> `v5.12.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgo-git%2fgo-git%2fv5/v5.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgo-git%2fgo-git%2fv5/v5.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgo-git%2fgo-git%2fv5/v5.11.0/v5.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgo-git%2fgo-git%2fv5/v5.11.0/v5.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/jedib0t/go-pretty/v6](https://togithub.com/jedib0t/go-pretty) | require | patch | `v6.5.6` -> `v6.5.8` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fjedib0t%2fgo-pretty%2fv6/v6.5.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fjedib0t%2fgo-pretty%2fv6/v6.5.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fjedib0t%2fgo-pretty%2fv6/v6.5.6/v6.5.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fjedib0t%2fgo-pretty%2fv6/v6.5.6/v6.5.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | golang.org/x/exp | require | digest | `a685a6e` -> `93d18d7` | | | | | | golang.org/x/mod | require | minor | `v0.16.0` -> `v0.17.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/golang.org%2fx%2fmod/v0.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/golang.org%2fx%2fmod/v0.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/golang.org%2fx%2fmod/v0.16.0/v0.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/golang.org%2fx%2fmod/v0.16.0/v0.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | golang.org/x/sync | require | minor | `v0.6.0` -> `v0.7.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/golang.org%2fx%2fsync/v0.7.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/golang.org%2fx%2fsync/v0.7.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/golang.org%2fx%2fsync/v0.6.0/v0.7.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/golang.org%2fx%2fsync/v0.6.0/v0.7.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | golang.org/x/term | require | minor | `v0.18.0` -> `v0.19.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/golang.org%2fx%2fterm/v0.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/golang.org%2fx%2fterm/v0.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/golang.org%2fx%2fterm/v0.18.0/v0.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/golang.org%2fx%2fterm/v0.18.0/v0.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [google.golang.org/grpc](https://togithub.com/grpc/grpc-go) | require | minor | `v1.62.1` -> `v1.63.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/google.golang.org%2fgrpc/v1.63.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/google.golang.org%2fgrpc/v1.63.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/google.golang.org%2fgrpc/v1.62.1/v1.63.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/google.golang.org%2fgrpc/v1.62.1/v1.63.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>gkampitakis/go-snaps (github.com/gkampitakis/go-snaps)</summary> ### [`v0.5.3`](https://togithub.com/gkampitakis/go-snaps/releases/tag/v0.5.3) [Compare Source](https://togithub.com/gkampitakis/go-snaps/compare/v0.5.2...v0.5.3) #### What's Changed - fix: race condition when updating snapshots in parallel by [@​gkampitakis](https://togithub.com/gkampitakis) in [https://github.com/gkampitakis/go-snaps/pull/97](https://togithub.com/gkampitakis/go-snaps/pull/97) **Full Changelog**: gkampitakis/go-snaps@v0.5.2...v0.5.3 </details> <details> <summary>go-git/go-git (github.com/go-git/go-git/v5)</summary> ### [`v5.12.0`](https://togithub.com/go-git/go-git/releases/tag/v5.12.0) [Compare Source](https://togithub.com/go-git/go-git/compare/v5.11.0...v5.12.0) #### What's Changed - git: Worktree.AddWithOptions: add skipStatus option when providing a specific path by [@​moranCohen26](https://togithub.com/moranCohen26) in [https://github.com/go-git/go-git/pull/994](https://togithub.com/go-git/go-git/pull/994) - git: Signer: fix usage of crypto.Signer interface by [@​wlynch](https://togithub.com/wlynch) in [https://github.com/go-git/go-git/pull/1029](https://togithub.com/go-git/go-git/pull/1029) - git: Remote, fetch, adds the prune option. by [@​juliens](https://togithub.com/juliens) in [https://github.com/go-git/go-git/pull/366](https://togithub.com/go-git/go-git/pull/366) - git: Add crypto.Signer option to CommitOptions. by [@​wlynch](https://togithub.com/wlynch) in [https://github.com/go-git/go-git/pull/996](https://togithub.com/go-git/go-git/pull/996) - git: Worktree checkout tag hash id ([#​959](https://togithub.com/go-git/go-git/issues/959)) by [@​aymanbagabas](https://togithub.com/aymanbagabas) in [https://github.com/go-git/go-git/pull/966](https://togithub.com/go-git/go-git/pull/966) - git: Worktree, Don't panic on empty or root path when checking if it is valid by [@​tim775](https://togithub.com/tim775) in [https://github.com/go-git/go-git/pull/1042](https://togithub.com/go-git/go-git/pull/1042) - git: Add commit validation for Reset by [@​pjbgf](https://togithub.com/pjbgf) in [https://github.com/go-git/go-git/pull/1048](https://togithub.com/go-git/go-git/pull/1048) - git: worktree_commit, Fix amend commit to apply changes. Fixes [#​1024](https://togithub.com/go-git/go-git/issues/1024) by [@​onee-only](https://togithub.com/onee-only) in [https://github.com/go-git/go-git/pull/1045](https://togithub.com/go-git/go-git/pull/1045) - git: Implement Merge function with initial `FastForwardMerge` support by [@​pjbgf](https://togithub.com/pjbgf) in [https://github.com/go-git/go-git/pull/1044](https://togithub.com/go-git/go-git/pull/1044) - plumbing: object, Make first commit visible on logs filtered with filename. Fixes [#​191](https://togithub.com/go-git/go-git/issues/191) by [@​onee-only](https://togithub.com/onee-only) in [https://github.com/go-git/go-git/pull/1036](https://togithub.com/go-git/go-git/pull/1036) - plumbing: no panic in printStats function. Fixes [#​177](https://togithub.com/go-git/go-git/issues/177) by [@​nodivbyzero](https://togithub.com/nodivbyzero) in [https://github.com/go-git/go-git/pull/971](https://togithub.com/go-git/go-git/pull/971) - plumbing: object, Optimize logging with file. by [@​onee-only](https://togithub.com/onee-only) in [https://github.com/go-git/go-git/pull/1046](https://togithub.com/go-git/go-git/pull/1046) - plumbing: object, check legitimacy in (\*Tree).Encode by [@​niukuo](https://togithub.com/niukuo) in [https://github.com/go-git/go-git/pull/967](https://togithub.com/go-git/go-git/pull/967) - plumbing: format/gitattributes, close file in ReadAttributesFile by [@​prskr](https://togithub.com/prskr) in [https://github.com/go-git/go-git/pull/1018](https://togithub.com/go-git/go-git/pull/1018) - plumbing: check setAuth error. Fixes [#​185](https://togithub.com/go-git/go-git/issues/185) by [@​nodivbyzero](https://togithub.com/nodivbyzero) in [https://github.com/go-git/go-git/pull/969](https://togithub.com/go-git/go-git/pull/969) - plumbing: object, fix variable defaultUtf8CommitMessageEncoding name spell error by [@​Jerry-yz](https://togithub.com/Jerry-yz) in [https://github.com/go-git/go-git/pull/987](https://togithub.com/go-git/go-git/pull/987) - utils: merkletrie, calculate filesystem node's hash lazily. by [@​candid82](https://togithub.com/candid82) in [https://github.com/go-git/go-git/pull/825](https://togithub.com/go-git/go-git/pull/825) - utils: update comment in node.go's Hash() by [@​codablock](https://togithub.com/codablock) in [https://github.com/go-git/go-git/pull/992](https://togithub.com/go-git/go-git/pull/992) - \_example: fix 404 link and added ssh-agent clone link by [@​grinish21](https://togithub.com/grinish21) in [https://github.com/go-git/go-git/pull/1022](https://togithub.com/go-git/go-git/pull/1022) - \_example: checkout-branch example by [@​dlambda](https://togithub.com/dlambda) in [https://github.com/go-git/go-git/pull/446](https://togithub.com/go-git/go-git/pull/446) - \_example: example for git clone using ssh-agent by [@​pjbgf](https://togithub.com/pjbgf) in [https://github.com/go-git/go-git/pull/998](https://togithub.com/go-git/go-git/pull/998) #### New Contributors - [@​candid82](https://togithub.com/candid82) made their first contribution in [https://github.com/go-git/go-git/pull/825](https://togithub.com/go-git/go-git/pull/825) - [@​codablock](https://togithub.com/codablock) made their first contribution in [https://github.com/go-git/go-git/pull/992](https://togithub.com/go-git/go-git/pull/992) - [@​Jerry-yz](https://togithub.com/Jerry-yz) made their first contribution in [https://github.com/go-git/go-git/pull/987](https://togithub.com/go-git/go-git/pull/987) - [@​wlynch](https://togithub.com/wlynch) made their first contribution in [https://github.com/go-git/go-git/pull/996](https://togithub.com/go-git/go-git/pull/996) - [@​moranCohen26](https://togithub.com/moranCohen26) made their first contribution in [https://github.com/go-git/go-git/pull/994](https://togithub.com/go-git/go-git/pull/994) - [@​grinish21](https://togithub.com/grinish21) made their first contribution in [https://github.com/go-git/go-git/pull/1022](https://togithub.com/go-git/go-git/pull/1022) - [@​prskr](https://togithub.com/prskr) made their first contribution in [https://github.com/go-git/go-git/pull/1018](https://togithub.com/go-git/go-git/pull/1018) - [@​dlambda](https://togithub.com/dlambda) made their first contribution in [https://github.com/go-git/go-git/pull/446](https://togithub.com/go-git/go-git/pull/446) - [@​juliens](https://togithub.com/juliens) made their first contribution in [https://github.com/go-git/go-git/pull/366](https://togithub.com/go-git/go-git/pull/366) - [@​onee-only](https://togithub.com/onee-only) made their first contribution in [https://github.com/go-git/go-git/pull/1036](https://togithub.com/go-git/go-git/pull/1036) - [@​tim775](https://togithub.com/tim775) made their first contribution in [https://github.com/go-git/go-git/pull/1042](https://togithub.com/go-git/go-git/pull/1042) - [@​niukuo](https://togithub.com/niukuo) made their first contribution in [https://github.com/go-git/go-git/pull/967](https://togithub.com/go-git/go-git/pull/967) - [@​avoidalone](https://togithub.com/avoidalone) made their first contribution in [https://github.com/go-git/go-git/pull/1047](https://togithub.com/go-git/go-git/pull/1047) **Full Changelog**: go-git/go-git@v5.11.0...v5.12.0 </details> <details> <summary>jedib0t/go-pretty (github.com/jedib0t/go-pretty/v6)</summary> ### [`v6.5.8`](https://togithub.com/jedib0t/go-pretty/releases/tag/v6.5.8) [Compare Source](https://togithub.com/jedib0t/go-pretty/compare/v6.5.7...v6.5.8) #### What's Changed - table: paging should work with auto-merge; fixes [#​315](https://togithub.com/jedib0t/go-pretty/issues/315) by [@​jedib0t](https://togithub.com/jedib0t) in [https://github.com/jedib0t/go-pretty/pull/317](https://togithub.com/jedib0t/go-pretty/pull/317) **Full Changelog**: jedib0t/go-pretty@v6.5.7...v6.5.8 ### [`v6.5.7`](https://togithub.com/jedib0t/go-pretty/releases/tag/v6.5.7) [Compare Source](https://togithub.com/jedib0t/go-pretty/compare/v6.5.6...v6.5.7) #### What's Changed - table: fix paging with separators; fixes [#​312](https://togithub.com/jedib0t/go-pretty/issues/312) by [@​jedib0t](https://togithub.com/jedib0t) in [https://github.com/jedib0t/go-pretty/pull/313](https://togithub.com/jedib0t/go-pretty/pull/313) **Full Changelog**: jedib0t/go-pretty@v6.5.6...v6.5.7 </details> <details> <summary>grpc/grpc-go (google.golang.org/grpc)</summary> ### [`v1.63.2`](https://togithub.com/grpc/grpc-go/releases/tag/v1.63.2): Release 1.63.2 [Compare Source](https://togithub.com/grpc/grpc-go/compare/v1.63.1...v1.63.2) ### Bugs - Fix the user agent string ### [`v1.63.1`](https://togithub.com/grpc/grpc-go/releases/tag/v1.63.1): Release 1.63.1 [Compare Source](https://togithub.com/grpc/grpc-go/compare/v1.63.0...v1.63.1) - grpc: un-deprecate Dial and DialContext and cherry-pick ### [`v1.63.0`](https://togithub.com/grpc/grpc-go/releases/tag/v1.63.0): Release 1.63.0 [Compare Source](https://togithub.com/grpc/grpc-go/compare/v1.62.2...v1.63.0) ### Behavior Changes - grpc: Return canonical target string from `resolver.Address.String()` (experimental) ([#​6923](https://togithub.com/grpc/grpc-go/issues/6923)) - client & server: when using write buffer pooling, use input value for buffer size instead of size\*2 ([#​6983](https://togithub.com/grpc/grpc-go/issues/6983)) - Special Thanks: [@​raghav-stripe](https://togithub.com/raghav-stripe) ### New Features - grpc: add `ClientConn.CanonicalTarget()` to return the canonical target string. ([#​7006](https://togithub.com/grpc/grpc-go/issues/7006)) - xds: implement LRS named metrics support ([gRFC A64](https://togithub.com/grpc/proposal/blob/master/A64-lrs-custom-metrics.md)) ([#​7027](https://togithub.com/grpc/grpc-go/issues/7027)) - Special Thanks: [@​danielzhaotongliu](https://togithub.com/danielzhaotongliu) - grpc: introduce `grpc.NewClient` to allow users to create new clients in idle mode and with "dns" as the default resolver ([#​7010](https://togithub.com/grpc/grpc-go/issues/7010)) - Special Thanks: [@​bruuuuuuuce](https://togithub.com/bruuuuuuuce) ### API Changes - grpc: stabilize experimental method `ClientConn.Target()` ([#​7006](https://togithub.com/grpc/grpc-go/issues/7006)) ### Bug Fixes - xds: fix an issue that would cause the client to send an empty list of resources for LDS/CDS upon reconnecting with the management server ([#​7026](https://togithub.com/grpc/grpc-go/issues/7026)) - server: Fix some errors returned by a server when using a `grpc.Server` as an `http.Handler` with the Go stdlib HTTP server ([#​6989](https://togithub.com/grpc/grpc-go/issues/6989)) - resolver/dns: add `SetResolvingTimeout` to allow configuring the DNS resolver's global timeout ([#​6917](https://togithub.com/grpc/grpc-go/issues/6917)) - Special Thanks: [@​and1truong](https://togithub.com/and1truong) - Set the security level of Windows named pipes to NoSecurity ([#​6956](https://togithub.com/grpc/grpc-go/issues/6956)) - Special Thanks: [@​irsl](https://togithub.com/irsl) ### [`v1.62.2`](https://togithub.com/grpc/grpc-go/releases/tag/v1.62.2): Release 1.62.2 [Compare Source](https://togithub.com/grpc/grpc-go/compare/v1.62.1...v1.62.2) ### Dependencies - Update http2 library to address vulnerability [CVE-2023-45288](https://www.kb.cert.org/vuls/id/421644) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on monday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/google/osv-scanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.