Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table: fix paging with separators; fixes #312 #313

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

jedib0t
Copy link
Owner

@jedib0t jedib0t commented Apr 5, 2024

No description provided.

Copy link

sonarcloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8572577894

Details

  • 41 of 41 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8411028109: 0.0%
Covered Lines: 3534
Relevant Lines: 3534

💛 - Coveralls

@jedib0t jedib0t merged commit d03b448 into main Apr 5, 2024
5 checks passed
@jedib0t jedib0t deleted the table-fix-paging branch April 5, 2024 16:08
another-rex referenced this pull request in google/osv-scanner Apr 9, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change | Age | Adoption | Passing |
Confidence |
|---|---|---|---|---|---|---|---|
| [deps.dev/api/v3](https://togithub.com/google/deps.dev) | require |
digest | `ff53416` -> `d32937c` | | | | |
| [deps.dev/util/maven](https://togithub.com/google/deps.dev) | require
| digest | `ff53416` -> `d32937c` | | | | |
| [deps.dev/util/resolve](https://togithub.com/google/deps.dev) |
require | digest | `ff53416` -> `d32937c` | | | | |
| [deps.dev/util/semver](https://togithub.com/google/deps.dev) | require
| digest | `ff53416` -> `d32937c` | | | | |
|
[github.com/gkampitakis/go-snaps](https://togithub.com/gkampitakis/go-snaps)
| require | patch | `v0.5.2` -> `v0.5.3` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgkampitakis%2fgo-snaps/v0.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgkampitakis%2fgo-snaps/v0.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgkampitakis%2fgo-snaps/v0.5.2/v0.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgkampitakis%2fgo-snaps/v0.5.2/v0.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [github.com/go-git/go-git/v5](https://togithub.com/go-git/go-git) |
require | minor | `v5.11.0` -> `v5.12.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgo-git%2fgo-git%2fv5/v5.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgo-git%2fgo-git%2fv5/v5.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgo-git%2fgo-git%2fv5/v5.11.0/v5.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgo-git%2fgo-git%2fv5/v5.11.0/v5.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[github.com/jedib0t/go-pretty/v6](https://togithub.com/jedib0t/go-pretty)
| require | patch | `v6.5.6` -> `v6.5.8` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fjedib0t%2fgo-pretty%2fv6/v6.5.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fjedib0t%2fgo-pretty%2fv6/v6.5.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fjedib0t%2fgo-pretty%2fv6/v6.5.6/v6.5.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fjedib0t%2fgo-pretty%2fv6/v6.5.6/v6.5.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| golang.org/x/exp | require | digest | `a685a6e` -> `93d18d7` | | | | |
| golang.org/x/mod | require | minor | `v0.16.0` -> `v0.17.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/golang.org%2fx%2fmod/v0.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/golang.org%2fx%2fmod/v0.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/golang.org%2fx%2fmod/v0.16.0/v0.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/golang.org%2fx%2fmod/v0.16.0/v0.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| golang.org/x/sync | require | minor | `v0.6.0` -> `v0.7.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/golang.org%2fx%2fsync/v0.7.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/golang.org%2fx%2fsync/v0.7.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/golang.org%2fx%2fsync/v0.6.0/v0.7.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/golang.org%2fx%2fsync/v0.6.0/v0.7.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| golang.org/x/term | require | minor | `v0.18.0` -> `v0.19.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/golang.org%2fx%2fterm/v0.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/golang.org%2fx%2fterm/v0.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/golang.org%2fx%2fterm/v0.18.0/v0.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/golang.org%2fx%2fterm/v0.18.0/v0.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [google.golang.org/grpc](https://togithub.com/grpc/grpc-go) | require
| minor | `v1.62.1` -> `v1.63.2` |
[![age](https://developer.mend.io/api/mc/badges/age/go/google.golang.org%2fgrpc/v1.63.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/google.golang.org%2fgrpc/v1.63.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/google.golang.org%2fgrpc/v1.62.1/v1.63.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/google.golang.org%2fgrpc/v1.62.1/v1.63.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>gkampitakis/go-snaps
(github.com/gkampitakis/go-snaps)</summary>

###
[`v0.5.3`](https://togithub.com/gkampitakis/go-snaps/releases/tag/v0.5.3)

[Compare
Source](https://togithub.com/gkampitakis/go-snaps/compare/v0.5.2...v0.5.3)

#### What's Changed

- fix: race condition when updating snapshots in parallel by
[@&#8203;gkampitakis](https://togithub.com/gkampitakis) in
[https://github.com/gkampitakis/go-snaps/pull/97](https://togithub.com/gkampitakis/go-snaps/pull/97)

**Full Changelog**:
gkampitakis/go-snaps@v0.5.2...v0.5.3

</details>

<details>
<summary>go-git/go-git (github.com/go-git/go-git/v5)</summary>

### [`v5.12.0`](https://togithub.com/go-git/go-git/releases/tag/v5.12.0)

[Compare
Source](https://togithub.com/go-git/go-git/compare/v5.11.0...v5.12.0)

#### What's Changed

- git: Worktree.AddWithOptions: add skipStatus option when providing a
specific path by
[@&#8203;moranCohen26](https://togithub.com/moranCohen26) in
[https://github.com/go-git/go-git/pull/994](https://togithub.com/go-git/go-git/pull/994)
- git: Signer: fix usage of crypto.Signer interface by
[@&#8203;wlynch](https://togithub.com/wlynch) in
[https://github.com/go-git/go-git/pull/1029](https://togithub.com/go-git/go-git/pull/1029)
- git: Remote, fetch, adds the prune option. by
[@&#8203;juliens](https://togithub.com/juliens) in
[https://github.com/go-git/go-git/pull/366](https://togithub.com/go-git/go-git/pull/366)
- git: Add crypto.Signer option to CommitOptions. by
[@&#8203;wlynch](https://togithub.com/wlynch) in
[https://github.com/go-git/go-git/pull/996](https://togithub.com/go-git/go-git/pull/996)
- git: Worktree checkout tag hash id
([#&#8203;959](https://togithub.com/go-git/go-git/issues/959)) by
[@&#8203;aymanbagabas](https://togithub.com/aymanbagabas) in
[https://github.com/go-git/go-git/pull/966](https://togithub.com/go-git/go-git/pull/966)
- git: Worktree, Don't panic on empty or root path when checking if it
is valid by [@&#8203;tim775](https://togithub.com/tim775) in
[https://github.com/go-git/go-git/pull/1042](https://togithub.com/go-git/go-git/pull/1042)
- git: Add commit validation for Reset by
[@&#8203;pjbgf](https://togithub.com/pjbgf) in
[https://github.com/go-git/go-git/pull/1048](https://togithub.com/go-git/go-git/pull/1048)
- git: worktree_commit, Fix amend commit to apply changes. Fixes
[#&#8203;1024](https://togithub.com/go-git/go-git/issues/1024) by
[@&#8203;onee-only](https://togithub.com/onee-only) in
[https://github.com/go-git/go-git/pull/1045](https://togithub.com/go-git/go-git/pull/1045)
- git: Implement Merge function with initial `FastForwardMerge` support
by [@&#8203;pjbgf](https://togithub.com/pjbgf) in
[https://github.com/go-git/go-git/pull/1044](https://togithub.com/go-git/go-git/pull/1044)
- plumbing: object, Make first commit visible on logs filtered with
filename. Fixes
[#&#8203;191](https://togithub.com/go-git/go-git/issues/191) by
[@&#8203;onee-only](https://togithub.com/onee-only) in
[https://github.com/go-git/go-git/pull/1036](https://togithub.com/go-git/go-git/pull/1036)
- plumbing: no panic in printStats function. Fixes
[#&#8203;177](https://togithub.com/go-git/go-git/issues/177) by
[@&#8203;nodivbyzero](https://togithub.com/nodivbyzero) in
[https://github.com/go-git/go-git/pull/971](https://togithub.com/go-git/go-git/pull/971)
- plumbing: object, Optimize logging with file. by
[@&#8203;onee-only](https://togithub.com/onee-only) in
[https://github.com/go-git/go-git/pull/1046](https://togithub.com/go-git/go-git/pull/1046)
- plumbing: object, check legitimacy in (\*Tree).Encode by
[@&#8203;niukuo](https://togithub.com/niukuo) in
[https://github.com/go-git/go-git/pull/967](https://togithub.com/go-git/go-git/pull/967)
- plumbing: format/gitattributes, close file in ReadAttributesFile by
[@&#8203;prskr](https://togithub.com/prskr) in
[https://github.com/go-git/go-git/pull/1018](https://togithub.com/go-git/go-git/pull/1018)
- plumbing: check setAuth error. Fixes
[#&#8203;185](https://togithub.com/go-git/go-git/issues/185) by
[@&#8203;nodivbyzero](https://togithub.com/nodivbyzero) in
[https://github.com/go-git/go-git/pull/969](https://togithub.com/go-git/go-git/pull/969)
- plumbing: object, fix variable defaultUtf8CommitMessageEncoding name
spell error by [@&#8203;Jerry-yz](https://togithub.com/Jerry-yz) in
[https://github.com/go-git/go-git/pull/987](https://togithub.com/go-git/go-git/pull/987)
- utils: merkletrie, calculate filesystem node's hash lazily. by
[@&#8203;candid82](https://togithub.com/candid82) in
[https://github.com/go-git/go-git/pull/825](https://togithub.com/go-git/go-git/pull/825)
- utils: update comment in node.go's Hash() by
[@&#8203;codablock](https://togithub.com/codablock) in
[https://github.com/go-git/go-git/pull/992](https://togithub.com/go-git/go-git/pull/992)
- \_example: fix 404 link and added ssh-agent clone link by
[@&#8203;grinish21](https://togithub.com/grinish21) in
[https://github.com/go-git/go-git/pull/1022](https://togithub.com/go-git/go-git/pull/1022)
- \_example: checkout-branch example by
[@&#8203;dlambda](https://togithub.com/dlambda) in
[https://github.com/go-git/go-git/pull/446](https://togithub.com/go-git/go-git/pull/446)
- \_example: example for git clone using ssh-agent by
[@&#8203;pjbgf](https://togithub.com/pjbgf) in
[https://github.com/go-git/go-git/pull/998](https://togithub.com/go-git/go-git/pull/998)

#### New Contributors

- [@&#8203;candid82](https://togithub.com/candid82) made their first
contribution in
[https://github.com/go-git/go-git/pull/825](https://togithub.com/go-git/go-git/pull/825)
- [@&#8203;codablock](https://togithub.com/codablock) made their first
contribution in
[https://github.com/go-git/go-git/pull/992](https://togithub.com/go-git/go-git/pull/992)
- [@&#8203;Jerry-yz](https://togithub.com/Jerry-yz) made their first
contribution in
[https://github.com/go-git/go-git/pull/987](https://togithub.com/go-git/go-git/pull/987)
- [@&#8203;wlynch](https://togithub.com/wlynch) made their first
contribution in
[https://github.com/go-git/go-git/pull/996](https://togithub.com/go-git/go-git/pull/996)
- [@&#8203;moranCohen26](https://togithub.com/moranCohen26) made their
first contribution in
[https://github.com/go-git/go-git/pull/994](https://togithub.com/go-git/go-git/pull/994)
- [@&#8203;grinish21](https://togithub.com/grinish21) made their first
contribution in
[https://github.com/go-git/go-git/pull/1022](https://togithub.com/go-git/go-git/pull/1022)
- [@&#8203;prskr](https://togithub.com/prskr) made their first
contribution in
[https://github.com/go-git/go-git/pull/1018](https://togithub.com/go-git/go-git/pull/1018)
- [@&#8203;dlambda](https://togithub.com/dlambda) made their first
contribution in
[https://github.com/go-git/go-git/pull/446](https://togithub.com/go-git/go-git/pull/446)
- [@&#8203;juliens](https://togithub.com/juliens) made their first
contribution in
[https://github.com/go-git/go-git/pull/366](https://togithub.com/go-git/go-git/pull/366)
- [@&#8203;onee-only](https://togithub.com/onee-only) made their first
contribution in
[https://github.com/go-git/go-git/pull/1036](https://togithub.com/go-git/go-git/pull/1036)
- [@&#8203;tim775](https://togithub.com/tim775) made their first
contribution in
[https://github.com/go-git/go-git/pull/1042](https://togithub.com/go-git/go-git/pull/1042)
- [@&#8203;niukuo](https://togithub.com/niukuo) made their first
contribution in
[https://github.com/go-git/go-git/pull/967](https://togithub.com/go-git/go-git/pull/967)
- [@&#8203;avoidalone](https://togithub.com/avoidalone) made their first
contribution in
[https://github.com/go-git/go-git/pull/1047](https://togithub.com/go-git/go-git/pull/1047)

**Full Changelog**:
go-git/go-git@v5.11.0...v5.12.0

</details>

<details>
<summary>jedib0t/go-pretty (github.com/jedib0t/go-pretty/v6)</summary>

###
[`v6.5.8`](https://togithub.com/jedib0t/go-pretty/releases/tag/v6.5.8)

[Compare
Source](https://togithub.com/jedib0t/go-pretty/compare/v6.5.7...v6.5.8)

#### What's Changed

- table: paging should work with auto-merge; fixes
[#&#8203;315](https://togithub.com/jedib0t/go-pretty/issues/315) by
[@&#8203;jedib0t](https://togithub.com/jedib0t) in
[https://github.com/jedib0t/go-pretty/pull/317](https://togithub.com/jedib0t/go-pretty/pull/317)

**Full Changelog**:
jedib0t/go-pretty@v6.5.7...v6.5.8

###
[`v6.5.7`](https://togithub.com/jedib0t/go-pretty/releases/tag/v6.5.7)

[Compare
Source](https://togithub.com/jedib0t/go-pretty/compare/v6.5.6...v6.5.7)

#### What's Changed

- table: fix paging with separators; fixes
[#&#8203;312](https://togithub.com/jedib0t/go-pretty/issues/312) by
[@&#8203;jedib0t](https://togithub.com/jedib0t) in
[https://github.com/jedib0t/go-pretty/pull/313](https://togithub.com/jedib0t/go-pretty/pull/313)

**Full Changelog**:
jedib0t/go-pretty@v6.5.6...v6.5.7

</details>

<details>
<summary>grpc/grpc-go (google.golang.org/grpc)</summary>

### [`v1.63.2`](https://togithub.com/grpc/grpc-go/releases/tag/v1.63.2):
Release 1.63.2

[Compare
Source](https://togithub.com/grpc/grpc-go/compare/v1.63.1...v1.63.2)

### Bugs

-   Fix the user agent string

### [`v1.63.1`](https://togithub.com/grpc/grpc-go/releases/tag/v1.63.1):
Release 1.63.1

[Compare
Source](https://togithub.com/grpc/grpc-go/compare/v1.63.0...v1.63.1)

-   grpc: un-deprecate Dial and DialContext and cherry-pick

### [`v1.63.0`](https://togithub.com/grpc/grpc-go/releases/tag/v1.63.0):
Release 1.63.0

[Compare
Source](https://togithub.com/grpc/grpc-go/compare/v1.62.2...v1.63.0)

### Behavior Changes

- grpc: Return canonical target string from `resolver.Address.String()`
(experimental)
([#&#8203;6923](https://togithub.com/grpc/grpc-go/issues/6923))
- client & server: when using write buffer pooling, use input value for
buffer size instead of size\*2
([#&#8203;6983](https://togithub.com/grpc/grpc-go/issues/6983))
- Special Thanks:
[@&#8203;raghav-stripe](https://togithub.com/raghav-stripe)

### New Features

- grpc: add `ClientConn.CanonicalTarget()` to return the canonical
target string.
([#&#8203;7006](https://togithub.com/grpc/grpc-go/issues/7006))
- xds: implement LRS named metrics support ([gRFC
A64](https://togithub.com/grpc/proposal/blob/master/A64-lrs-custom-metrics.md))
([#&#8203;7027](https://togithub.com/grpc/grpc-go/issues/7027))
- Special Thanks:
[@&#8203;danielzhaotongliu](https://togithub.com/danielzhaotongliu)
- grpc: introduce `grpc.NewClient` to allow users to create new clients
in idle mode and with "dns" as the default resolver
([#&#8203;7010](https://togithub.com/grpc/grpc-go/issues/7010))
- Special Thanks:
[@&#8203;bruuuuuuuce](https://togithub.com/bruuuuuuuce)

### API Changes

- grpc: stabilize experimental method `ClientConn.Target()`
([#&#8203;7006](https://togithub.com/grpc/grpc-go/issues/7006))

### Bug Fixes

- xds: fix an issue that would cause the client to send an empty list of
resources for LDS/CDS upon reconnecting with the management server
([#&#8203;7026](https://togithub.com/grpc/grpc-go/issues/7026))
- server: Fix some errors returned by a server when using a
`grpc.Server` as an `http.Handler` with the Go stdlib HTTP server
([#&#8203;6989](https://togithub.com/grpc/grpc-go/issues/6989))
- resolver/dns: add `SetResolvingTimeout` to allow configuring the DNS
resolver's global timeout
([#&#8203;6917](https://togithub.com/grpc/grpc-go/issues/6917))
- Special Thanks: [@&#8203;and1truong](https://togithub.com/and1truong)
- Set the security level of Windows named pipes to NoSecurity
([#&#8203;6956](https://togithub.com/grpc/grpc-go/issues/6956))
    -   Special Thanks: [@&#8203;irsl](https://togithub.com/irsl)

### [`v1.62.2`](https://togithub.com/grpc/grpc-go/releases/tag/v1.62.2):
Release 1.62.2

[Compare
Source](https://togithub.com/grpc/grpc-go/compare/v1.62.1...v1.62.2)

### Dependencies

- Update http2 library to address vulnerability
[CVE-2023-45288](https://www.kb.cert.org/vuls/id/421644)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 6am on monday" in timezone
Australia/Sydney, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/google/osv-scanner).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants