progress: Overall ETA never less than max ETA #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5987034044
💛 - Coveralls |
|
Hey @NathanBaulch ... can you rebase this PR please? I merged your other one, and this needs to incorp those changes. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current overall ETA doesn't really work because all the fast trackers finish quickly leaving the slow ones, meaning the current naive calculation always underestimates the ETA.
IMO the overall tracker ETA should never be less than the longest ETA of the active trackers. There are a couple of ways this could be done, but introducing a
maxETAfield onTrackerwas the easiest without majorly refactoring the way overall trackers work.Here are before and after graphs that show the ETA reported (blue) vs the actual ETA (orange) in my project. They both have a lot of instability initially but the second does a much better job at guestimating the ETA once it settles.
Note - this PR also includes some general code cleanup. Let me know if you'd like this separated.