Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress: Render never started trackers properly #273

Merged
merged 2 commits into from
Aug 26, 2023

Conversation

NathanBaulch
Copy link
Contributor

Minor tweak to the renderTrackerStatsTime function for the case when deferred start trackers are marked done without ever being started. Includes a unit test.

Note - this PR also includes some general code cleanup. Let me know if you'd like this separated.

@coveralls
Copy link

coveralls commented Aug 25, 2023

Pull Request Test Coverage Report for Build 5984294002

  • 34 of 34 (100.0%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 5844611332: 0.0%
Covered Lines: 3302
Relevant Lines: 3302

💛 - Coveralls

@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jedib0t
Copy link
Owner

jedib0t commented Aug 26, 2023

Thanks for the contribution! And I really appreciate the other cleanup!

@jedib0t jedib0t merged commit 13d3a1d into jedib0t:main Aug 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants