-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
progress: support rendering trackers that haven't started yet #270
Conversation
Pull Request Test Coverage Report for Build 5839435394
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. I should be able to merge within a day or two after you address the one comment.
Is it possible to share a demo gif of this in action?
progress/tracker.go
Outdated
@@ -25,6 +25,8 @@ type Tracker struct { | |||
// Units defines the type of the "value" being tracked | |||
Units Units | |||
|
|||
DeferStart bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move it below the Message variable and add a comment on how this is used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
e0efbb4
to
d26938d
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
I guess so, though it's pretty easy to see in action in |
Reason I asked was I'm doing this on mobile and won't have access to a computer for a couple of days. It's all right. I'll check before I merge then. |
OK, I gave asciinema a try for the first time, pretty neat! |
Ha, you merged it just minutes before I pushed a fix for the sorting suggestion above :) |
Proposed Changes
Support displaying trackers that haven't started yet.
I have a complex process that includes tasks that depend on the completion of other tasks. I'd like to display trackers for these deferred tasks without actually starting the clock or animating the indeterminate ones.
This PR has: