Uncurries internals for rescript 11 compatibility #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illusionalsagacity
force-pushed
the
uncurry-internals-works-on-rescript-10
branch
2 times, most recently
from
b0f2f25 to
fb07b98
Compare
…e on either curried/uncurried
illusionalsagacity
force-pushed
the
uncurry-internals-works-on-rescript-10
branch
from
fb07b98 to
d1d4967
Compare
jeddeloh
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the internal usage of most externals or function definitions used at runtime to be explicitly uncurried functions. The intent here is that the
Js_modules are changed, not the public API. This will eliminate any ambiguous function calling conventions when the consumer of this library is on ReScript v10 or v11 on curried mode.