Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix options creation for @apollo/client >= 3.5 #134

Merged

Conversation

illusionalsagacity
Copy link
Contributor

Resolves #133

@illusionalsagacity illusionalsagacity changed the title Fix options creation apollo 3 5 Fix options creation for @apollo/client >= 3.5 Dec 21, 2021
@illusionalsagacity
Copy link
Contributor Author

Smoke tested this on a branch of my employer's app, definitely fixes the immediate crash on startup.

Copy link
Owner

@jeddeloh jeddeloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Gonna wait to merge a bit in case you get to comments

@illusionalsagacity
Copy link
Contributor Author

:shipit: Gonna wait to merge a bit in case you get to comments

Yeah I can get to them in a bit

@jeddeloh
Copy link
Owner

Excellent! Thanks again! I also tested in /EXAMPLES and things look good. I checked that mutation options already use abstract/obj but subscription doesn't. I'm going to go ahead in a subsequent PR and convert subscription as well.

@jeddeloh jeddeloh merged commit 2c17c20 into jeddeloh:master Dec 22, 2021
@illusionalsagacity illusionalsagacity deleted the fix-options-creation-apollo-3-5 branch December 22, 2021 17:51
@jeddeloh
Copy link
Owner

Oh, ignore me. You already did it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility/Bug with @apollo/client > 3.5.0
2 participants