Skip to content

Commit

Permalink
CLI: Suppress printing out of password to console when using auth com…
Browse files Browse the repository at this point in the history
…mand (apache#2857)

---------

Co-authored-by: Eric Pugh <[email protected]>
  • Loading branch information
malliaridis and epugh authored Dec 12, 2024
1 parent 57eabb5 commit aadac83
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
2 changes: 2 additions & 0 deletions solr/CHANGES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,8 @@ Improvements
* SOLR-16470: Replication "fetch file" API now has a v2 equivalent, available at `GET /api/cores/coreName/replication/files/fileName`
(Matthew Biscocho via Jason Gerlowski)

* SOLR-17554: Suppress printing out of password to console when using auth CLI command. (Christos Malliaridis via Eric Pugh)


Optimizations
---------------------
Expand Down
5 changes: 1 addition & 4 deletions solr/core/src/java/org/apache/solr/cli/AuthTool.java
Original file line number Diff line number Diff line change
Expand Up @@ -282,10 +282,7 @@ private void handleBasicAuth(CommandLine cli) throws Exception {
updateIncludeFileEnableAuth(includeFile, basicAuthConfFile);
final String successMessage =
String.format(
Locale.ROOT,
"Successfully enabled basic auth with username [%s] and password [%s].",
username,
password);
Locale.ROOT, "Successfully enabled basic auth with username [%s].", username);
echo(successMessage);
return;
case "disable":
Expand Down

0 comments on commit aadac83

Please sign in to comment.