Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow plugins overriding core plugins #2155

Merged
merged 1 commit into from
May 20, 2024
Merged

fix: allow plugins overriding core plugins #2155

merged 1 commit into from
May 20, 2024

Conversation

jdx
Copy link
Owner

@jdx jdx commented May 20, 2024

A recent bug caused core plugins to override local ones. This is temporary to patch mise, this will be soon fixed along with some tests to verify that core plugin overriding continues to function.

A recent bug caused core plugins to override local ones
Copy link

Code Coverage

Package Line Rate Complexity Health
src 87% 0
src.cli 83% 0
src.cli.alias 89% 0
src.cli.args 96% 0
src.cli.backends 95% 0
src.cli.cache 95% 0
src.cli.config 92% 0
src.cli.direnv 80% 0
src.cli.generate 93% 0
src.cli.plugins 87% 0
src.cli.settings 93% 0
src.cli.sync 29% 0
src.cli.tasks 71% 0
src.config.config_file 89% 0
src.config 87% 0
src.forge 77% 0
src.plugins.core 56% 0
src.plugins 79% 0
src.shell 98% 0
src.toolset 86% 0
src.ui 64% 0
Summary 81% (13663 / 16789) 0

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% 80.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (bb1556e) 16791 13668 81.40%
Head commit (0b9a317) 16789 (-2) 13663 (-5) 81.38% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#2155) 10 8 80.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@jdx jdx merged commit 51750b8 into main May 20, 2024
12 checks passed
@jdx jdx deleted the fix-node-plugin branch May 20, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant