Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(self-update): do not update to latest version in test #2013

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

jdx
Copy link
Owner

@jdx jdx commented May 2, 2024

this fails during releases if we use the latest since it won't have any assets yet

@jdx jdx enabled auto-merge (squash) May 2, 2024 01:33
@jdx jdx changed the title fix(self_update): show --version param fix(self_update): update to specific version in test May 2, 2024
@jdx jdx disabled auto-merge May 2, 2024 01:36
Copy link

codacy-production bot commented May 2, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+2.73%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e5368f7) 16761 13268 79.16%
Head commit (a6372f1) 16761 (+0) 13725 (+457) 81.89% (+2.73%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#2013) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@jdx jdx changed the title fix(self_update): update to specific version in test fix(self_update): do not update to latest version in test May 2, 2024
@jdx jdx enabled auto-merge (squash) May 2, 2024 01:43
@jdx jdx changed the title fix(self_update): do not update to latest version in test fix(self-update): do not update to latest version in test May 2, 2024
@jdx jdx disabled auto-merge May 2, 2024 01:47
@jdx jdx merged commit a330837 into main May 2, 2024
8 checks passed
@jdx jdx deleted the self-update branch May 2, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant