Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(java): inconsistent version resolution" #1993

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

jdx
Copy link
Owner

@jdx jdx commented Apr 29, 2024

Reverts #1957

caused a bug:

$ mise install java@corretto-8 --verbose
[DEBUG] ARGS: target/debug/mise i java@corretto-8 --verbose
[DEBUG] Config {
    Config Files: [
        "~/src/mise/.mise.local.toml",
        "~/src/mise/.mise.toml",
        "~/src/mise/.mise/config.toml",
        "~/src/mise/.tool-versions",
        "~/src/mise/.node-version",
        "~/.mise/config.toml",
        "~/.config/mise/config.toml",
        "~/.tool-versions",
    ],
    Env: {
        "FOO_FROM_FILE": "foo_from_file",
        "FOO": ".mise.local.toml",
        "FOO_NUM": "1",
        "THIS_PROJECT": "/Users/jdx/src/mise-/Users/jdx/src/mise",
    },
    Path Dirs: [
        "/Users/jdx/src/mise/target/debug",
    ],
    Aliases: {
        ForgeArg("tiny"): {
            "abc": "1",
        },
    },
}
[DEBUG] Toolset: tiny@1, go@prefix:1.21, python@latest, [email protected], shfmt@3, cargo:cargo-edit@latest, cargo:cargo-show@latest, cargo:git-cliff@latest, npm:[email protected], npm:prettier@3, jq@latest, node@lts/hydrogen, ruby@latest, java@22
Error: 
   0: no metadata found for version corretto-8

Location:
   src/plugins/core/java.rs:276

Version:
   2024.4.8-DEBUG macos-arm64 (1060234 2024-04-29)

Suggestion: Run with --verbose or MISE_VERBOSE=1 for more information.

@jdx jdx enabled auto-merge (squash) April 29, 2024 22:56
Copy link

codacy-production bot commented Apr 29, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+25.70% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ed91c1c) 14306 7999 55.91%
Head commit (bc7a9b1) 16764 (+2458) 13682 (+5683) 81.62% (+25.70%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1993) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@jdx jdx merged commit 07884eb into main Apr 29, 2024
8 checks passed
@jdx jdx deleted the revert-1957-issues/1887 branch April 29, 2024 22:58
@jdx jdx linked an issue Apr 29, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"No metadata found for version corretto-21" using the java installer
1 participant