Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings refactor #1174

Merged
merged 4 commits into from
Dec 14, 2023
Merged

settings refactor #1174

merged 4 commits into from
Dec 14, 2023

Conversation

jdx
Copy link
Owner

@jdx jdx commented Dec 14, 2023

  • refactor: parse CLI into settings partial
  • whitespace
  • refactor: memoize partial settings

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2e74638) 84.33% compared to head (8c31b74) 81.18%.

Files Patch % Lines
src/config/settings.rs 93.10% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1174      +/-   ##
==========================================
- Coverage   84.33%   81.18%   -3.15%     
==========================================
  Files         136      136              
  Lines       12844    12860      +16     
==========================================
- Hits        10832    10441     -391     
- Misses       2012     2419     +407     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 5 0 0.14s
✅ BASH bash-exec 19 0 0.04s
✅ BASH shellcheck 19 0 0.44s
✅ BASH shfmt 19 0 0 0.04s
✅ DOCKERFILE hadolint 7 0 0.19s
✅ EDITORCONFIG editorconfig-checker 471 0 0.58s
✅ JSON eslint-plugin-jsonc 7 0 0 1.01s
✅ JSON jsonlint 6 0 0.15s
✅ JSON prettier 7 0 0 0.67s
✅ JSON v8r 7 0 4.31s
✅ MARKDOWN markdownlint 13 0 0 2.8s
✅ MARKDOWN markdown-link-check 13 0 15.82s
✅ MARKDOWN markdown-table-formatter 13 0 0 0.41s
✅ PYTHON bandit 1 0 0.72s
✅ PYTHON black 1 0 0 0.52s
✅ PYTHON flake8 1 0 0.32s
✅ PYTHON isort 1 0 0 0.29s
✅ PYTHON mypy 1 0 2.25s
✅ PYTHON pylint 1 0 1.27s
✅ PYTHON pyright 1 0 6.07s
✅ PYTHON ruff 1 0 0 0.04s
✅ REPOSITORY dustilock yes no 0.01s
✅ REPOSITORY gitleaks yes no 2.47s
✅ REPOSITORY git_diff yes no 0.03s
✅ REPOSITORY secretlint yes no 2.32s
✅ REPOSITORY syft yes no 0.5s
✅ REPOSITORY trivy-sbom yes no 1.01s
✅ REPOSITORY trufflehog yes no 5.94s
✅ RUBY rubocop 2 0 0 5.07s
✅ RUST clippy yes no 106.75s
✅ XML xmllint 5 0 0 0.03s
✅ YAML prettier 12 0 0 1.21s
✅ YAML v8r 12 0 12.52s
✅ YAML yamllint 12 0 0.4s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

@jdx jdx merged commit 6a6441e into main Dec 14, 2023
7 of 8 checks passed
@jdx jdx deleted the settings-refactor branch December 14, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant