Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uninstall: allow uninstalling all matching #1144

Merged
merged 1 commit into from
Dec 12, 2023
Merged

uninstall: allow uninstalling all matching #1144

merged 1 commit into from
Dec 12, 2023

Conversation

jdx
Copy link
Owner

@jdx jdx commented Dec 12, 2023

With this change, rtx uninstall node@20 will uninstall all node versions starting with "20". If multiple match, --all needs to be passed.

Fixes #1115

Copy link

github-actions bot commented Dec 12, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 5 0 0.11s
✅ BASH bash-exec 19 0 0.04s
✅ BASH shellcheck 19 0 0.38s
✅ BASH shfmt 19 0 0 0.04s
✅ DOCKERFILE hadolint 7 0 0.13s
✅ EDITORCONFIG editorconfig-checker 468 0 0.44s
✅ JSON eslint-plugin-jsonc 7 0 0 1.01s
✅ JSON jsonlint 6 0 0.15s
✅ JSON prettier 7 0 0 0.76s
✅ JSON v8r 7 0 4.69s
✅ MARKDOWN markdownlint 13 0 0 2.7s
✅ MARKDOWN markdown-link-check 13 0 17.53s
✅ MARKDOWN markdown-table-formatter 13 0 0 0.38s
✅ PYTHON bandit 1 0 0.72s
✅ PYTHON black 1 0 0 0.59s
✅ PYTHON flake8 1 0 0.34s
✅ PYTHON isort 1 0 0 0.32s
✅ PYTHON mypy 1 0 2.12s
✅ PYTHON pylint 1 0 1.25s
✅ PYTHON pyright 1 0 5.87s
✅ PYTHON ruff 1 0 0 0.05s
✅ REPOSITORY dustilock yes no 0.01s
✅ REPOSITORY gitleaks yes no 2.2s
✅ REPOSITORY git_diff yes no 0.04s
✅ REPOSITORY secretlint yes no 2.29s
✅ REPOSITORY syft yes no 0.41s
✅ REPOSITORY trivy-sbom yes no 1.02s
✅ REPOSITORY trufflehog yes no 3.23s
✅ RUBY rubocop 2 0 0 4.89s
✅ RUST clippy yes no 103.25s
✅ XML xmllint 5 0 0 0.04s
✅ YAML prettier 12 0 0 1.14s
✅ YAML v8r 12 0 11.44s
✅ YAML yamllint 12 0 0.29s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

@jdx jdx force-pushed the uninstall-multi branch 2 times, most recently from acaeb50 to ceabb04 Compare December 12, 2023 20:07
@jdx jdx changed the title uninstall: tweak behavior uninstall: allow uninstalling all matching Dec 12, 2023
@jdx jdx marked this pull request as ready for review December 12, 2023 20:08
@jdx jdx enabled auto-merge (squash) December 12, 2023 20:09
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (360491c) 79.73% compared to head (6ae3934) 84.37%.

Files Patch % Lines
src/cli/uninstall.rs 75.80% 15 Missing ⚠️
src/toolset/tool_version.rs 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1144      +/-   ##
==========================================
+ Coverage   79.73%   84.37%   +4.63%     
==========================================
  Files         138      138              
  Lines       12674    12721      +47     
==========================================
+ Hits        10106    10733     +627     
+ Misses       2568     1988     -580     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdx jdx merged commit ab3acf5 into main Dec 12, 2023
8 checks passed
@jdx jdx deleted the uninstall-multi branch December 12, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uninstall behavior should change slightly
1 participant