[ISSUE-1110] handle null in java plugin #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkoosha
force-pushed
the
issue-1110/java-plugin-image-type-null-values
branch
from
ab1f173
to
2293918
Compare
jdx
reviewed
Dec 7, 2023
src/plugins/core/java.rs
Outdated
| @@ -239,7 +239,9 @@ impl JavaPlugin { | |||
| .http | |||
| .json::<Vec<JavaMetadata>, _>(url)? | |||
| .into_iter() | |||
| .filter(|m| JAVA_FILE_TYPES.contains(&m.file_type)) | |||
| .filter(|m| { | |||
| m.file_type.is_some() && JAVA_FILE_TYPES.contains(&m.file_type.clone().unwrap()) | |||
There was a problem hiding this comment.
use is_some_and for this and the next change
hkoosha
force-pushed
the
issue-1110/java-plugin-image-type-null-values
branch
from
2293918
to
ef20859
Compare
hkoosha
force-pushed
the
issue-1110/java-plugin-image-type-null-values
branch
from
ef20859
to
70d127d
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1111 +/- ##
==========================================
- Coverage 87.37% 85.37% -2.01%
==========================================
Files 137 137
Lines 12551 12564 +13
==========================================
- Hits 10967 10727 -240
- Misses 1584 1837 +253 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1110