Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to confique for settings management #1074

Merged
merged 1 commit into from
Dec 4, 2023
Merged

switch to confique for settings management #1074

merged 1 commit into from
Dec 4, 2023

Conversation

jdx
Copy link
Owner

@jdx jdx commented Dec 4, 2023

this is just an initial pass that switches over just the env var and defaults, more work will need to be done

@jdx jdx changed the title confique switch to confique for settings management Dec 4, 2023
@jdx jdx force-pushed the confique branch 2 times, most recently from 0ae04cb to 9c6a97d Compare December 4, 2023 03:03
@jdx jdx marked this pull request as ready for review December 4, 2023 03:11
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (322425f) 85.93% compared to head (7456fb1) 79.01%.

Files Patch % Lines
src/config/settings.rs 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1074      +/-   ##
==========================================
- Coverage   85.93%   79.01%   -6.92%     
==========================================
  Files         133      133              
  Lines       12382    12345      -37     
==========================================
- Hits        10641     9755     -886     
- Misses       1741     2590     +849     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdx jdx enabled auto-merge (squash) December 4, 2023 03:18
@jdx jdx merged commit aabe269 into main Dec 4, 2023
14 of 15 checks passed
@jdx jdx deleted the confique branch December 4, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant