-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
completions should complete plugins + versions #97
Comments
looks promising, if I can find some time to have a deeper look I can check more. I like how simple this is for fish! |
ok I got this working for zsh. I'll do it for fish too but not the other shells (these are a massive pain to write) |
I think Bash is really the most common shell so it would be awesome if that could be supported in time too. 😄 |
You are free to open a PR for this and implement it. Maybe @jdx will merge it with a disclaimer that they won't support it 😄 |
Zsh is the default on macOS and the most common shell by this point. https://www.warp.dev/state-of-the-cli-2023#shell-preferences-and-personalizations |
Well that's from a terminal that's only available for MacOS and therefore not representative. I assume most servers will have bash preinstalled for example. |
@jdx My shell is fish |
@jdx Thanks for your excellent project ❯ rtx ls --installed | awk '{print $1 "@" $2}'
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
...
❯ rtx uninstall [email protected]
rtx [email protected] uninstalled
❯ rtx ls --installed | awk '{print $1 "@" $2}'
[email protected]
[email protected]
[email protected]
[email protected]
... but ❯ rtx uninstall elixir@<tab><tab>
…[email protected] (Tool(s) to remove)
…[email protected] (Tool(s) to remove)
…[email protected] (Tool(s) to remove)
…[email protected] (Tool(s) to remove) Last version is uninstalled |
@Stanislav-Lapata it should show installed versions now. I'm also working on bash for some unrelated reasons. |
the completions right now only help complete things like command names and option names.
Ideally you should be able to complete with something like this:
This probably is non-trivial, but it would certainly be nice.
EDIT: this is working now, but some improvements can be made (I would welcome some help!)
rtx uninstall
should only show installed versions (perhaps other commands as well)rtx install <tab><tab>
starts off showing ancient bun versions. (see my comment about this below)rtx settings set <tab><tab>
The text was updated successfully, but these errors were encountered: