Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to install hadolint package #42

Closed
pedropombeiro opened this issue Jan 29, 2023 · 3 comments
Closed

Fails to install hadolint package #42

pedropombeiro opened this issue Jan 29, 2023 · 3 comments

Comments

@pedropombeiro
Copy link

I have hadolint v2.10.0 on my ~/.tool-versions file. When I run rtx install it stops midway due to:

rtx: Installing runtime: [email protected]
* Downloading hadolint release v2.10.0...
curl: (22) The requested URL returned error: 404
asdf-hadolint: Could not download https://github.com/hadolint/hadolint/releases/download/vv2.10.0/hadolint-Darwin-x86_64
rtx: error command ["/Users/pedropombeiro/.local/share/rtx/plugins/hadolint/bin/download"] exited with code 1
rtx: Run with RTX_DEBUG=1 for more information.

It looks like it doesn't like the v prefix in the version, but asdf wants it. It would be nice to have this working so that it is possible to run asdf and rtx on the same project (different team members can have different preferences).

@jdx
Copy link
Owner

jdx commented Jan 30, 2023

asdf doesn't seem to require the v:

❯ echo 'hadolint 2.10.0' >> .tool-versions

~
❯ asdf install hadolint
* Downloading hadolint release 2.10.0...
hadolint 2.10.0 installation was successful!
hadolint 2.10.0 is already installed

I could also strip v as any prefix but I'm worried that might have unintended consequences down the road. I think for now the best solution is not to use v in .tool-versions.

I'll think about it though. It's also not a super simple change though as I need to make sure this step is done in many places.

@jdx
Copy link
Owner

jdx commented Jan 31, 2023

@pedropombeiro Let me know if you think not allowing "v" prefixes is acceptable or not. I think it should be, but let me know if I'm missing something.

@pedropombeiro
Copy link
Author

@jdxcode I don't know if at one point the asdf list all hadolint returned versions with the v prefix, which is how that got into my .tool-versions file. Nowadays that seems to be fixed, so I would say we can close this.

@jdx jdx closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2023
jdx pushed a commit that referenced this issue Jun 1, 2024
* fix(java): add legacy version files section

* fix(java): update list of supported JDKs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants