Test files have different target directories than program files when compiled (flycheck) #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…compiled When compiling a test file its target directory is normally something bellow "test-classes". Regular classes are compiled to "classes" directory. Thus regular classes and test classes have different jdee-compile-option-directory in the same project. A solution to this issue is to make jdee-compile-option-directory a buffer local variable and set its value accordingly in prj.el . But flycheck cannot known where to put the compiled file, so the solution I propose is to copy jdee-compile-option-directory value from original buffer if it was set.
pwojnowski
reviewed
Aug 25, 2018
| ;; test-classes, not classes. Runtime classes and test classes have | ||
| ;; different jdee-compile-option-directory in the same project. | ||
| (let ((v (buffer-local-value 'jdee-compile-option-directory orig-buffer))) | ||
| (if v (set 'jdee-compile-option-directory v))) |
There was a problem hiding this comment.
But where jdee-compile-option-directory will be set to test-classes value? You would need to recognize if you are in test sources or main sources.
There was a problem hiding this comment.
Sorry for such a late reply.
There was a problem hiding this comment.
In prj.el it is possible to set the jdee-compile-option-directory based in the full path filename, in a local version of the variable. In my case I do it like this:
(setq
jdee-compile-option-directory
(cond
((string-match
".*\\(/\\(src/main/java\\)/.*\\)" default-directory)
(replace-match "/target/classes/" t nil default-directory 1))
((string-match
".*\\(/\\(src/test/java\\)/.*\\)" default-directory)
(replace-match "/target/test-classes/" t nil default-directory 1))
(t (error "%s" (concat "Destiny of '" (buffer-file-name)
"' compiled file is unknown")))) )With the change jdee-flycheck can give one a chance to set the compiled file location. I hope this patch can flourish a better idea!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling a test file its target directory is normally something bellow "test-classes". Regular classes are compiled to "classes" directory. Thus regular classes and test classes have different jdee-compile-option-directory in the same project.
A solution to this issue is to make jdee-compile-option-directory a buffer local variable and set its value accordingly in prj.el . But flycheck cannot known where to put the compiled file, so the solution I propose is to copy jdee-compile-option-directory value from original buffer if it was set.
The greater goal here is to have the compiled file in the right place as maven/ant would do, without compiling it twice (one for check, other the "real" compilation).
Thanks