Fix some incorrect SGR codes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test-script is incorrectly using SGR 26 to cancel SGR 6, but SGR 5 and SGR 6 are _both_ cancelled by SGR 25. SGR 26 is unrelated. This fixes the issue that the 'no rapid blink' text is blinking in Windows Terminal, which implements all of SGR 5, 6 and 25; although it does not differentiate SGR 5 and SGR 6's blink speed. References: * https://en.wikipedia.org/wiki/ANSI_escape_code#SGR_(Select_Graphic_Rendition)_parameters * Page 61 of https://www.ecma-international.org/wp-content/uploads/ECMA-48_5th_edition_june_1991.pdf * https://www.real-world-systems.com/docs/ANSIcode.html Signed-off-by: Paul "TBBle" Hampson <[email protected]>
Per the standard, the `:` character is the separator for the elements of the parameter substring. However, the parameter substring itself is still separated from the SGR value using `;`. References: * 13.1.8 of ISO/IEC 8613-6:1994 (E), aka IT-T Rec. T.416 (1993 E) * https://github.com/csdvrx/sixel-testsuite/blob/master/ansi-vte52.sh Signed-off-by: Paul "TBBle" Hampson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across this as a suggested test suite for Windows Terminal, and while trying it out, I hit a few issues:
Windows Terminal doesn't currently implement the latter, but there was a fair bit of research done on microsoft/terminal#4321 as preparation work. Per https://gist.github.com/XVilka/8346728#gistcomment-2774523 there is some ambiguity in the specification, so for the purposes of this repo, it might make sense to make that change toggleable as well?