Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add username to the directory of readers #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MayuriJain15
Copy link

No description provided.

@jdblischak
Copy link
Owner

@MayuriJain15 Thanks for reading the tutorial and submitting a Pull Request!

The file you created is named username.txt. The goal is that every contributor names the files using their own username, which in your case would be MayuriJain15.txt.

This is a great opportunity to practice updating a Pull Request after receiving feedback. This will often happen when you contribute to other projects. Running the code below from the git-for-science repository on your local machine will update the filename, commit the change, and then push the change back to GitHub.

# Rename the file
git mv readers/username.txt readers/MayuriJain15.txt
# Commit the change
git commit -m "Change filename to username"
# Push the changes back to your fork. The PR will automatically update
git push origin master

Please do not hesitate to ask if you have any questions!

@jdblischak
Copy link
Owner

@MayuriJain15 did you try running the commands I shared above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants