Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major Release v36.0.0 - Improved Typing, and API support (16.0) #2258

Merged
merged 24 commits into from
Apr 26, 2023

Conversation

jdalrymple
Copy link
Owner

@jdalrymple jdalrymple commented Dec 2, 2021

UPDATE: While testing is happening on the canary version released, I'm working on filling in some gaps to allow for support up to 15.11. I might as well have the latest support after all this work haha - Currently at the Snippets section of the docs, tackling about 6-10 sections per day!

Summary

  • Updating library to match latest 15.x API
  • Updating typing to use explicit return types on all exposed functions
  • Removing 'version' as a Resource parameter. v4 will be hardcoded
  • Begin adding version support information with each release.
  • Combine Node.js and Browser release

Supported Versions: 16.0 Excluding Alpha APIS (Debian group/project distributions, Dependencies)

fixes #2084
fixes #1897
fixes #2311
fixes #2296
fixes #2267
fixes #2295
fixes #2172
fixes #2276
fixes #2319
fixes #1449
fixes #1906
fixes #2072
fixes #2322
closes #1592
closes #2463
closes #2450
closes #2683
closes #2838
closes #2683
fixes #2673
closes #2670
fixes #2700
fixes #2609
fixes #2483
fixes #2461
closes #1906
closes #2083
fixes #2843
fixes #2794
fixes #2731
fixes #3122

📦 Published PR as canary version: 36.0.2--canary.2258.849927821.0

✨ Test out this PR locally via:

npm install @gitbeaker/[email protected]
npm install @gitbeaker/[email protected]
npm install @gitbeaker/[email protected]
npm install @gitbeaker/[email protected]
# or 
yarn add @gitbeaker/[email protected]
yarn add @gitbeaker/[email protected]
yarn add @gitbeaker/[email protected]
yarn add @gitbeaker/[email protected]

This was referenced Jan 3, 2022
@jdalrymple jdalrymple changed the title Adding explicit types for all resources Update typing and API support to 14.x Jan 7, 2022
@jdalrymple jdalrymple force-pushed the 1897-explicit-typing branch from 699b603 to 55af718 Compare January 8, 2022 00:20
@jdalrymple
Copy link
Owner Author

jdalrymple commented Jan 9, 2022

Update: Currently at the Issue Stats API. 🥲 still a lot to go haha

@jdalrymple
Copy link
Owner Author

Update: At the Maven API

@jdalrymple
Copy link
Owner Author

Update: At the Notes API!

@jdalrymple
Copy link
Owner Author

Progress! At the protected environments API

@lunodan
Copy link

lunodan commented Aug 3, 2022

Hello! What's the deal with this MR? Do you need any help?

@jdalrymple jdalrymple changed the title Update typing and API support to 14.x Update typing and API support to 15.x Aug 5, 2022
@jdalrymple
Copy link
Owner Author

@lunodan Im going to review the status of this over the next week and follow up. I finally have a bit of time to jump back on this, but honestly forget where I was in the PR. I know i was running through the testing, but where i stopped is beyond me haha.

@jdalrymple
Copy link
Owner Author

Hmm good catch. I should change it such that the slash isn't important thinking

You could use the built-in URL.

Exactly what i was thinking! Implemented and being deployed now!

@salim-runsafe
Copy link

@jdalrymple at least with ProjectAccessToken, that drops projects from the URL.

https://gitlab.com/api/v4/12345678/access_tokens should be https://gitlab.com/api/v4/projects/12345678/access_tokens

@jdalrymple
Copy link
Owner Author

@jdalrymple at least with ProjectAccessToken, that drops projects from the URL.

https://gitlab.com/api/v4/12345678/access_tokens should be https://gitlab.com/api/v4/projects/12345678/access_tokens

100p, something is off. Ill give it a look! Thanks for following up

@jdalrymple
Copy link
Owner Author

jdalrymple commented Apr 6, 2023

Apparently, the URL instance doesnt like the input:

let a = new URL('21015560/access_tokens','https://gitlab.com/api/v4/projects')

a.toString()

//"https://gitlab.com/api/v4/21015560/access_tokens"


Gonna reread the docs to see where i went wrong. They have a similar example, but im not sure...why haha

UPDATE: I need to append a slash at the end of the base url to make it capture it correctly. sigh

@salim-runsafe
Copy link

@jdalrymple it looks like we didn't get a build with the latest fix because of a pipeline failure. Is that something you can address?

@jdalrymple
Copy link
Owner Author

@jdalrymple it looks like we didn't get a build with the latest fix because of a pipeline failure. Is that something you can address?

Ill sort it!

@jdalrymple jdalrymple merged commit 7493480 into main Apr 26, 2023
@jdalrymple jdalrymple deleted the 1897-explicit-typing branch April 26, 2023 16:26
@jdalrymple jdalrymple changed the title Major Release v36.0.0 - Improved Typing, and API support (15.7) Major Release v36.0.0 - Improved Typing, and API support (16.0) Apr 26, 2023
jdalrymple added a commit that referenced this pull request Apr 26, 2023
Adding extensive typing support
Unified browser and Node.JS implementations
Adding support of Gitlab API 16.0
jdalrymple added a commit that referenced this pull request Apr 26, 2023
Adding extensive typing support
Unified browser and Node.JS implementations
Adding support of Gitlab API 16.0
@jdalrymple
Copy link
Owner Author

🚀 PR was released in 37.0.0 🚀

@jdalrymple jdalrymple added the released This issue/pull request has been released. label Apr 26, 2023
@jdalrymple jdalrymple mentioned this pull request Apr 27, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment