Drop runtime dependency on setuptools for entrypoint enumeration and version parsing #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a long time now, pkg_resources has depended on a (possibly vendored) copy of the packaging module, and imports `Version` as `parse_version`. Use the original class directly. Add a direct dependency on packaging to make sure it's visibly required. pkg_resources is deprecated and the recommended replacement is to directly use packaging where relevant. The result is faster to load, and more guaranteed to work e.g. in environments where setuptools isn't installed by default.
pkg_resources is deprecated and the recommended replacement is to use importlib.metadata where relevant. The result is faster to load, and more guaranteed to work e.g. in environments where setuptools isn't installed by default.
|
I could not run tests in CI due to #165 but it seems to pass locally via tox. |
jd
approved these changes
Jan 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
globally replace pkg_resources.parse_version with non-aliased class
For a long time now, pkg_resources has depended on a (possibly vendored) copy of the packaging module, and imports
Versionasparse_version.Use the original class directly. Add a direct dependency on packaging to make sure it's visibly required.
pkg_resources is deprecated and the recommended replacement is to directly use packaging where relevant. The result is faster to load, and more guaranteed to work e.g. in environments where setuptools isn't installed by default.
drop dependency on setuptools at runtime to enumerate entrypoints
pkg_resources is deprecated and the recommended replacement is to use importlib.metadata where relevant. The result is faster to load, and more guaranteed to work e.g. in environments where setuptools isn't installed by default.