Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "expected str instance, bytes found" #118

Closed
wants to merge 1 commit into from
Closed

Fix "expected str instance, bytes found" #118

wants to merge 1 commit into from

Conversation

progval
Copy link

@progval progval commented Dec 26, 2018

Hi,

After a fresh install, I was getting this when running pifpaf run postgresql:

ERROR [pifpaf] sequence item 0: expected str instance, bytes found

This PR turns the error into:

ERROR [pifpaf] Unable to run command `[b'/usr/lib/postgresql/9.6/bin/pg_ctl', '-o', "'-A trust'", 'initdb']': [Errno 2] No such file or directory: b'/usr/lib/postgresql/9.6/bin/pg_ctl'

Thanks for making pifpaf, btw!

jd added a commit that referenced this pull request Jan 2, 2019
@jd
postgresql: fix encoding of pgctl path
da19b23 
This should be a regular string and not bytes. Otherwise in case of error
(pg_ctl not found), this happens:
  ERROR [pifpaf] sequence item 0: expected str instance, bytes found

Closes #118
@jd jd mentioned this pull request Jan 2, 2019
Merged
@jd
Copy link
Owner

jd commented Jan 2, 2019

@progval The bug is real, but the fix isn't good. Can you check if #119 works for you?

@jd jd closed this Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@progval @jd