feat: tabs使用横纵方向，标题支持左对齐 #2809
Merged
feat: tabs使用横纵方向，标题支持左对齐 #2809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4 #2809 +/- ##
==========================================
- Coverage 85.23% 84.97% -0.26%
==========================================
Files 166 166
Lines 21190 21211 +21
Branches 2390 2405 +15
==========================================
- Hits 18061 18024 -37
- Misses 3124 3170 +46
- Partials 5 17 +12 ☔ View full report in Codecov by Sentry. |
eiinu
reviewed
Jan 2, 2024
src/packages/__VUE/tabs/types.ts
Outdated
| @@ -11,3 +11,4 @@ export type RectItem = { | |||
| export type TabsDirection = 'horizontal' | 'vertical'; | |||
| export type TabsSize = 'large' | 'normal' | 'small'; | |||
| export type TabsType = 'line' | 'smile'; | |||
| export type Alignment = 'left' | 'center'; | |||
There was a problem hiding this comment.
建议 prop 名称改为 align，同时其类型名称为 TabsAlign
|
需要在文档中新增对应属性的 demo 示例，具体写法可参考 贡献指南-文档与 demo |
eiinu
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
tabs使用横纵方向，标题支持左对齐
resolve #2471
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台:
这个 PR 是否已自测: