CI: Add explicit static check script vendor test

Update the `check_vendor()` function in the static check script to run
our current vendoring tool (`dep`) in check mode. This will ensure our
vendoring does not get silently broken [1].

Fixes kata-containers#1506.

[1] - See for example kata-containers/runtime#1442.

Signed-off-by: James O. D. Hunt <[email protected]>
(cherry picked from commit 830983f)
Signed-off-by: Ganesh Maharaj Mahalingam <[email protected]>

.ci/static-checks.sh

@@ -608,11 +608,15 @@ check_files()
 	exit 1
 }
 
-# Ensure that changes to vendored code are accompanied by an update to the
-# vendor tooling config file. If not, the user simply hacked the vendor files
-# rather than following the correct process:
+# Perform vendor checks:
 #
-# - https://github.com/kata-containers/community/blob/master/VENDORING.md
+# - Ensure that changes to vendored code are accompanied by an update to the
+#   vendor tooling config file. If not, the user simply hacked the vendor files
+#   rather than following the correct process:
+#
+#   https://github.com/kata-containers/community/blob/master/VENDORING.md
+#
+# - Ensure vendor metadata is valid.
 check_vendor()
 {
 	local files
@@ -642,6 +646,14 @@ check_vendor()
 			[ -n "$result" ] || die "PR changes vendor files, but does not update ${vendor_ctl_file}"
 		fi
 	fi
+
+	info "Checking vendoring metadata"
+
+	# Get the vendoring tool
+	go get github.com/golang/dep/cmd/dep
+
+	# Check, but don't touch!
+	dep ensure -no-vendor -dry-run
 }
 
 main()