Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set security from key-management or guess if not available #92

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Set security from key-management or guess if not available #92

merged 2 commits into from
Sep 27, 2024

Conversation

cfconrad
Copy link
Collaborator

@cfconrad cfconrad commented Sep 16, 2024 •
edited by jcronenberg
Loading

Problem

Fixes: #81

Solution

Testing

@jcronenberg jcronenberg marked this pull request as draft September 17, 2024 08:19
@jcronenberg jcronenberg changed the title Draft: Set securiy from key-management or guess if not available Set securiy from key-management or guess if not available Sep 17, 2024
@jcronenberg jcronenberg changed the title Set securiy from key-management or guess if not available Set security from key-management or guess if not available Sep 17, 2024
@cfconrad cfconrad force-pushed the wireless_key_mgmt branch 4 times, most recently from 6c7dcb4 to 8ccf015 Compare September 25, 2024 06:52
@coveralls
Copy link

coveralls commented Sep 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11067919001

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 63 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+2.8%) to 47.507%
Files with Coverage Reduction New Missed Lines %
rust/src/wireless.rs 63 45.65%
Totals Coverage Status
Change from base Build 11041745181: 2.8%
Covered Lines: 324
Relevant Lines: 682
💛 - Coveralls

@cfconrad cfconrad marked this pull request as ready for review September 25, 2024 08:20
@cfconrad cfconrad marked this pull request as draft September 25, 2024 09:27
@cfconrad cfconrad marked this pull request as ready for review September 26, 2024 07:50
jcronenberg
jcronenberg reviewed Sep 26, 2024
View reviewed changes
rust/migrate-wicked/src/wireless.rs Outdated Show resolved Hide resolved
rust/migrate-wicked/src/wireless.rs Outdated Show resolved Hide resolved
@jcronenberg jcronenberg merged commit f0cf339 into jcronenberg:wicked-nm-migration Sep 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcronenberg jcronenberg jcronenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle no key-management set for wireless
3 participants
@cfconrad @coveralls @jcronenberg