Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global static dns migration via loopback interface #76

Merged
merged 8 commits into from
Sep 2, 2024
Merged

Add global static dns migration via loopback interface #76

merged 8 commits into from
Sep 2, 2024

Conversation

jcronenberg
Copy link
Owner

Problem

No netconfig static dns migration

Solution

Add static dns migration

Fixes: #34
An alternative to #75

Testing

  • Added a new integration test
  • Tested manually

@jcronenberg jcronenberg added upstream Something needs to be changed/implemented upstream migration Something needs to be changed/implemented in the wicked migration labels Mar 12, 2024
@jcronenberg jcronenberg requested a review from cfconrad March 12, 2024 14:42
@coveralls
Copy link

coveralls commented Mar 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10663618852

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 116 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-2.2%) to 51.306%
Files with Coverage Reduction New Missed Lines %
rust/src/main.rs 29 4.88%
rust/src/reader.rs 31 6.78%
rust/src/migrate.rs 56 0.0%
Totals Coverage Status
Change from base Build 10634881194: -2.2%
Covered Lines: 275
Relevant Lines: 536
💛 - Coveralls

@jcronenberg jcronenberg force-pushed the loopback_static_dns branch 2 times, most recently from b8f4662 to f7faf05 Compare August 12, 2024 14:51
@jcronenberg jcronenberg removed the upstream Something needs to be changed/implemented upstream label Aug 12, 2024
@jcronenberg jcronenberg marked this pull request as ready for review August 12, 2024 14:57
@cfconrad cfconrad force-pushed the loopback_static_dns branch from 089af85 to 2f6ebcc Compare August 30, 2024 13:34
@cfconrad
Copy link
Collaborator

cfconrad commented Sep 2, 2024

Are you ok with my suggestion 2f6ebcc ?

@jcronenberg
Copy link
Owner Author

Are you ok with my suggestion 2f6ebcc ?

Yea, sure.

cfconrad
cfconrad approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@cfconrad cfconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cfconrad cfconrad merged commit 25d1d15 into wicked-nm-migration Sep 2, 2024
4 checks passed
@jcronenberg jcronenberg mentioned this pull request Sep 2, 2024
Closed
@jcronenberg jcronenberg deleted the loopback_static_dns branch September 2, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfconrad cfconrad cfconrad approved these changes

Assignees
No one assigned
Labels
migration Something needs to be changed/implemented in the wicked migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add static DNS server migration
3 participants
@jcronenberg @coveralls @cfconrad