Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wireless migration #69

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Wireless migration #69

merged 4 commits into from
Apr 8, 2024

Conversation

jcronenberg
Copy link
Owner

@jcronenberg jcronenberg commented Jan 24, 2024

Problem

No wireless migration

Solution

Add wireless migration

Fixes: #33

Testing

  • Added a new integration test
  • Added new unit tests
  • Tested manually

@jcronenberg jcronenberg added upstream Something needs to be changed/implemented upstream migration Something needs to be changed/implemented in the wicked migration labels Jan 24, 2024
Copy link

github-actions bot commented Jan 24, 2024

Pull Request Test Coverage Report for Build 7709980972

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 42 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+3.1%) to 51.529%

Files with Coverage Reduction New Missed Lines %
rust/src/migrate.rs 10 0.0%
rust/src/main.rs 15 0.0%
rust/src/interface.rs 17 85.22%
Totals Coverage Status
Change from base Build 7709946881: 3.1%
Covered Lines: 219
Relevant Lines: 425

💛 - Coveralls

@jcronenberg jcronenberg force-pushed the wireless_migration branch 2 times, most recently from fdc5d92 to a134f65 Compare January 25, 2024 10:26
imobachgs added a commit to agama-project/agama that referenced this pull request Jan 29, 2024
## Problem

For the migration there are a few wireless options that yast2lan has
that are missing in agama.

## Solution

Add the missing options.

## Testing

- *Added new unit tests*
- *Tested manually*
- *Tested with the migration:
jcronenberg#69
@jcronenberg jcronenberg mentioned this pull request Jan 29, 2024
@jcronenberg jcronenberg removed the upstream Something needs to be changed/implemented upstream label Jan 29, 2024
@jcronenberg jcronenberg force-pushed the wireless_migration branch 2 times, most recently from 8163ece to 0ec3059 Compare January 29, 2024 14:35
@jcronenberg jcronenberg marked this pull request as ready for review January 29, 2024 15:08
imobachgs added a commit to agama-project/agama that referenced this pull request Jan 29, 2024
## Problem

Wireless property hidden is missing in network model.


## Solution

Add property. Sorry that I forgot it in my previous PR.


## Testing

- *Extended unit test*
- *Tested manually*
- *Tested with the migration
jcronenberg#69
@jcronenberg jcronenberg marked this pull request as draft January 29, 2024 16:08
@jcronenberg jcronenberg marked this pull request as ready for review January 30, 2024 11:02
@jcronenberg jcronenberg requested a review from cfconrad January 30, 2024 11:03
Copy link
Collaborator

@cfconrad cfconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! LGTM!

@cfconrad cfconrad merged commit 4c30d40 into wicked-nm-migration Apr 8, 2024
4 checks passed
@jcronenberg jcronenberg deleted the wireless_migration branch April 8, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration Something needs to be changed/implemented in the wicked migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Wireless
2 participants