forked from agama-project/agama
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wireless migration #69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcronenberg
added
upstream
Something needs to be changed/implemented upstream
migration
Something needs to be changed/implemented in the wicked migration
labels
Jan 24, 2024
Pull Request Test Coverage Report for Build 7709980972
💛 - Coveralls |
jcronenberg
force-pushed
the
wireless_migration
branch
2 times, most recently
from
January 25, 2024 10:26
fdc5d92
to
a134f65
Compare
imobachgs
added a commit
to agama-project/agama
that referenced
this pull request
Jan 29, 2024
## Problem For the migration there are a few wireless options that yast2lan has that are missing in agama. ## Solution Add the missing options. ## Testing - *Added new unit tests* - *Tested manually* - *Tested with the migration: jcronenberg#69
Merged
jcronenberg
removed
the
upstream
Something needs to be changed/implemented upstream
label
Jan 29, 2024
jcronenberg
force-pushed
the
wireless_migration
branch
2 times, most recently
from
January 29, 2024 14:35
8163ece
to
0ec3059
Compare
jcronenberg
force-pushed
the
wireless_migration
branch
from
January 29, 2024 15:10
0ec3059
to
29020e5
Compare
imobachgs
added a commit
to agama-project/agama
that referenced
this pull request
Jan 29, 2024
## Problem Wireless property hidden is missing in network model. ## Solution Add property. Sorry that I forgot it in my previous PR. ## Testing - *Extended unit test* - *Tested manually* - *Tested with the migration jcronenberg#69
jcronenberg
commented
Jan 29, 2024
jcronenberg
force-pushed
the
wireless_migration
branch
from
January 30, 2024 10:49
2b45f32
to
5f7e26f
Compare
jcronenberg
force-pushed
the
wireless_migration
branch
from
February 8, 2024 12:06
5f7e26f
to
26cb00a
Compare
cfconrad
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay! LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
No wireless migration
Solution
Add wireless migration
Fixes: #33
Testing