Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement VLAN #43

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Implement VLAN #43

merged 4 commits into from
Jan 25, 2024

Conversation

cfconrad
Copy link
Collaborator

@cfconrad cfconrad commented Nov 28, 2023 •
edited
Loading

Problem

Short description of the original problem.

Solution

Testing

  • Added a new unit test
  • Tested manually

Screenshots

If the fix affects the UI attach some screenshots here.

@cfconrad cfconrad marked this pull request as draft November 29, 2023 16:00
@cfconrad cfconrad force-pushed the impl_vlan branch 2 times, most recently from 7213236 to c32caa2 Compare December 7, 2023 14:07
@cfconrad cfconrad force-pushed the impl_vlan branch 3 times, most recently from e019fb5 to 91f4378 Compare January 12, 2024 14:03
@cfconrad
Copy link
Collaborator Author

Waiting for agama-project#918

@cfconrad cfconrad requested a review from jcronenberg January 25, 2024 14:39
@cfconrad cfconrad marked this pull request as ready for review January 25, 2024 14:39
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7656112261

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.5%) to 52.516%
Totals Coverage Status
Change from base Build 7654652645: 1.5%
Covered Lines: 167
Relevant Lines: 318
💛 - Coveralls

jcronenberg
jcronenberg requested changes Jan 25, 2024
View reviewed changes
rust/migrate-wicked/src/vlan.rs Outdated Show resolved Hide resolved
rust/migrate-wicked/src/vlan.rs Show resolved Hide resolved
rust/migrate-wicked/src/vlan.rs Outdated Show resolved Hide resolved
rust/migrate-wicked/tests/vlan/wicked_xml/vlan.xml Outdated Show resolved Hide resolved
@jcronenberg jcronenberg changed the title Draft: Implement VLAN Implement VLAN Jan 25, 2024
@jcronenberg jcronenberg merged commit 5514997 into jcronenberg:wicked-nm-migration Jan 25, 2024
2 checks passed
@cfconrad cfconrad deleted the impl_vlan branch January 25, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcronenberg jcronenberg jcronenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Vlan
3 participants
@cfconrad @coveralls @jcronenberg