Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add startmode migration #102

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Add startmode migration #102

merged 2 commits into from
Nov 28, 2024

Conversation

jcronenberg
Copy link
Owner

Description

Adds the missing migration for wicked's STARTMODE in ifcfg or <control><mode> in xml.
Added both integration and unit tests.
Fixes: #63

@jcronenberg jcronenberg added enhancement New feature or request migration Something needs to be changed/implemented in the wicked migration labels Nov 26, 2024
@jcronenberg jcronenberg requested a review from cfconrad November 26, 2024 12:12
@coveralls
Copy link

coveralls commented Nov 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12048143265

Details

  • 5 of 7 (71.43%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 49.128%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/interface.rs 5 7 71.43%
Totals Coverage Status
Change from base Build 11727466477: 0.2%
Covered Lines: 338
Relevant Lines: 688
💛 - Coveralls

@jcronenberg jcronenberg marked this pull request as draft November 26, 2024 14:17
@jcronenberg jcronenberg marked this pull request as ready for review November 26, 2024 15:22
clemix-fpv
clemix-fpv approved these changes Nov 28, 2024
View reviewed changes
Copy link

@clemix-fpv clemix-fpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cfconrad
cfconrad approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@cfconrad cfconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cfconrad cfconrad merged commit a2140d8 into split_migration Nov 28, 2024
4 checks passed
@jcronenberg jcronenberg deleted the startmode branch November 28, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemix-fpv clemix-fpv clemix-fpv approved these changes

@cfconrad cfconrad cfconrad approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request migration Something needs to be changed/implemented in the wicked migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add device activation control
4 participants
@jcronenberg @coveralls @cfconrad @clemix-fpv