Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to not activate connection immediately #20

Closed
jcronenberg opened this issue Nov 15, 2023 · 0 comments · Fixed by #54
Closed

Add option to not activate connection immediately #20

jcronenberg opened this issue Nov 15, 2023 · 0 comments · Fixed by #54
Labels
bug Something isn't working migration Something needs to be changed/implemented in the wicked migration

Comments

@jcronenberg
Copy link
Owner

Currently when we run


the following line is always executed
self.activate_connection(path).await?;

But because the migration is supposed to often be run from a container where the interfaces aren't available an error
[ERROR] Could not add/update the connection en0: D-Bus service error
gets logged even though everything else went well. (See e.g. our integration testsuite)

To avoid this I see 2 possibilities:

  • add a flag inside the network model if the connection should be activated or not
  • modify the write() and add_or_update_connection() functions to take a parameter if connections should be activated or not
@jcronenberg jcronenberg added bug Something isn't working upstream Something needs to be changed/implemented upstream labels Nov 15, 2023
imobachgs added a commit to agama-project/agama that referenced this issue Dec 15, 2023
## Problem

Currently a connection always gets activated when it is added.
This is a problem for the wicked migration described here
jcronenberg#20

## Solution

Add `Up` and `Down` state to `Status` to control this behavior.

## Testing

- *Tested manually*
- *Tested in the wicked migration
https://github.com/jcronenberg/agama/tree/skip-activation*
@jcronenberg jcronenberg added migration Something needs to be changed/implemented in the wicked migration and removed upstream Something needs to be changed/implemented upstream labels Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working migration Something needs to be changed/implemented in the wicked migration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant