Refactor float parsing #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors the number parsing routine (str -> int/float), with the following results: - Improved performance, up to 20% faster, dependent on message. This is most prominent for floats or long ints. - Ability to reuse the same routine for converting strings to ints or floats (or int/float-like things). Previously we had a duplicate `str -> int` routine, and relied on cpython's float parser for the `str -> float` conversions. With this change we're able to delete a bunch of code. - Expanded features. In particular, we can now support float-like strings as dict keys in JSON. - Improved maintainability. The reorganized code should provide a better base to build new features off of.
We can now roundtrip dicts with float-like keys through JSON.
jcrist
force-pushed
the
refactor-float-parsing
branch
from
0e1640c
to
e09969d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the number parsing routine (str -> int/float), with the following results:
str -> introutine, and relied on cpython's float parser for thestr -> floatconversions. With this change we're able to delete a bunch of code.This also adds support for encoding dicts with floats as keys (the keys are encoded as strings).