Support encoding decimals as numbers #465
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we always encoded
decimal.Decimal
values as strings. While this is the best format for these types (prevents precision loss, widely supported), sometimes there is a need to encodeDecimal
objects the same as numbers. This adds a newdecimal_format
option to allEncoder
classes. This value defaults to"string"
(to encode decimals as strings), but may be set to"number"
to encode them the same as the protocol's numeric types.We opt not to support this configuration in the top-level
encode
functions for now, since this is a less-common setting.Fixes #440.