[joss review] Update Makefiles #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @victorapm - Sorry for the late reply. I had to relocate to Oregon this past month, and it was just now that I had the time to sit down and take care of the library. I saw your changes, thanks for proposing them. I'll proceed with the approval. Thank you for the kind words! |
|
Glad this was helpful. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jcorbino, kudos on this cool package!
Regarding openjournals/joss-reviews#6288, In the process of going over the installation procedure, I implemented a few changes to the Makefiles to improve user experience:
ARMAis not definedSUPERLU=PATH_GOES_HERE makemake DEBUG=1Hope this is useful to you