Remove multibinder, change it to an alias of reusesocket #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcmoraisjr
force-pushed
the
jm-rm-multibinder
branch
from
d2522a7
to
e744287
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub's multibinder isn't compatible with HAProxy 1.8. Since the new
-xHAProxy command-line option uses the same strategy - reusing the same sockets between old and new HAProxy process,multibinderis being deprecated and removed on behalf ofreusesocketreload-strategy. If the user points the reload-strategy to multibinder, he will be warned (logs) and reusesocket will be used instead.