Allow options to bubble upstream, support 304s. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JackCA, can you take a look? |
|
|
||
| if (processedCache && jqXHR.status === 304) { | ||
| // Cache is valid, do nothing. | ||
| return; |
There was a problem hiding this comment.
Aren't we in danger of something chaining off of this with a null value?
There was a problem hiding this comment.
I don't think so... Line 433 doesn't have a return either. So the return value from 437 doesn't go anywhere.
|
👍 |
|
Cool -- there is a small API change in the V2 ajax method. This should probably be a major version bump. |
This was referenced Jul 14, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a V1 model, when doing something like
Comment.all(post, { cache: true }),$.ajax()doesn't get thecacheoption passed to it. This means we can't use the ETag/If-None-Match caching built into ajax on APIs that support it. There is also aifModifiedoption for$.ajax()with similar functionality that doesn't get sent up through RestModel V1.Additionally, when an ETag is still valid, we don't need to update the cached response. In both V1 and V2, we now abort processing and updating in the case of 302 (not modified) responses.