Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use openweather api 3.0 #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xmanwms95
Copy link

openweather api 2.5 will be deprecated in June 2024 https://openweathermap.org/one-call-transfer

openweather api 2.5 will be deprecated in June 2024
https://openweathermap.org/one-call-transfer
@KristjanESPERANTO
Copy link

@xmanwms95 Since @jclarke0000 has not responded to issues for a long time and generally seems to have no activity on his GitHub account, it might be a good idea to continue maintaining the module in a fork. Would you be willing to do that?

@BKeyport
Copy link

Please do that, xman. If J. Clarke comes back, he can always pick it back up. In the meantime, we've got fixes.

@Tom-Hirschberger
Copy link

Sh... Saw this pull request to late and made a fork which allows to configure the URL as a config option.

@KristjanESPERANTO
Copy link

Sh... Saw this pull request to late and made a fork which allows to configure the URL as a config option.

Even better 👍 Can we switch to your fork?

@Tom-Hirschberger
Copy link

Sure if you like. But i can only guarantee for basic support.
I use the module by my self and will try to keep it running. But I am very busy with my new born twins at the moment.

Make sure to set the new base url in the config as the fork still uses the 2.5 API in default. The instructions are part of the updated Readme.

@lxne
Copy link

lxne commented May 20, 2024

But I am very busy with my new born twins at the moment.

Congrats! That is definitely a challenge.
Best wishes
Alex

@KristjanESPERANTO
Copy link

Basic support would be awesome. But even if you can not provide support, a working fork would already be a good step ahead.

Would be nice if you would accept the change of the clone command: Tom-Hirschberger#1

P.S.: Congratulations on the twins! 👍😀

@Tom-Hirschberger
Copy link

Thanks and accepted

@goldyfruit
Copy link

Maybe this should be merged now #36

@Tom-Hirschberger
Copy link

Hi in my fork the problem is solved since months

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants