Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a basic Dockerfile #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mkohn
Copy link

@mkohn mkohn commented Nov 15, 2020

No description provided.

@jckuester
Copy link
Owner

Hi @mkohn,

sorry for my late reply here. Thanks for providing Docker support 👍

Generally, I am not sure why using awsls via a container is useful since awsls comes as a compiled binary that runs natively on many platforms already. Can you help me understand your usecase?

If we add Docker support, I have the following suggestions. Let me know what you think:

  1. add the Docker image to the github registry via goreleaser like here https://github.com/rothgar/ssm-helpers/blob/master/.goreleaser.yml#L55
  2. Is it maybe sufficient to simply use a FROM scratch instead of an alpine base image like here https://github.com/rothgar/ssm-helpers/blob/master/Dockerfile.ssm-run?

@mkohn
Copy link
Author

mkohn commented Apr 8, 2021

Personally, I dislike installing anything on my laptop directly. Additionally, I'm a consultant and work with many customers that require different versions of software, I got in the habit of running all software inside a docker container.

100% this container could be optimized to start from scratch. I was just starting with an MVP.

@gliptak
Copy link
Contributor

gliptak commented Apr 13, 2021

many utilities started providing Docker images (with or without publishing). no need for install (and keeping up-to-date) and also allowing to run specific version are both very valuable with a Docker based setup

https://docs.github.com/en/packages/guides/configuring-docker-for-use-with-github-packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants